Date: Sun, 13 Dec 2015 19:26:04 +0100
From: Frederik <frederik.voelkel@fau.de>
To: Nicolai Stange <nicstange@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org,
        linux-serial@vger.kernel.org, jslaby@suse.com,
        linux-kernel@i4.cs.fau.de, lukas.braun@fau.de
Subject: Re: [PATCH 0/9] Fix checkpatch errors
Message-ID: <20151213182604.GC11792@faumail.uni-erlangen.de>
References: <1449830170-15096-1-git-send-email-frederik.voelkel@fau.de>
 <20151213070622.GA13621@kroah.com>
 <20151213174429.GB11792@faumail.uni-erlangen.de>
 <87poyamczv.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87poyamczv.fsf@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1559
Lines: 43

On Sun, 13. Dec 19:15, Nicolai Stange wrote:
> Frederik <frederik.voelkel@fau.de> writes:
> 
> > On Sat, 12. Dec 23:06, Greg KH wrote:
> >> On Fri, Dec 11, 2015 at 11:36:00AM +0100, Frederik V?lkel wrote:
> >> > This patch series fixes all checkpatch error in 68328serial.c except
> >> > 5 trailing whitespace errors we are unsure how to fix.
> >> 
> >> What are the errors you are not sure how to fix?
> >> 
> >> thanks,
> >> 
> >> greg k-h
> >
> > All 5 errors are at comments. It is not clear to us where exactly the
> > trailing whitespace is checkpatch complains(lines 271, 770, 889, 993
> > and 1040).
> 
> W/o your series applied (so line numbering might be slightly
> different), checkpatch.pl says:
> 
>   ERROR: trailing whitespace
>   #270: FILE: -:270:
>   +^I * This do { } while() loop will get ALL chars out of Rx FIFO $
> 
> AFAICS, your patch [7/9] ("drivers: tty: 68328serial.c: remove trailing
> whitespaces") doesn't fix this one.
> 
> In good old regexp tradition, the '$' sign denotes the end of line. So,
> there is a single space after "FIFO" and before the end of line.
> 
> If you happen to be Emacs users, consider trying out whitespace-mode.
> If not, try to find another way to make your editor visualize whitespace
> somehow.

Oh right I see. We will fix that and resend.

Thank you!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/