Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752682AbbLMU1X (ORCPT ); Sun, 13 Dec 2015 15:27:23 -0500 Received: from proxima.lp0.eu ([81.2.80.65]:37357 "EHLO proxima.lp0.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752571AbbLMU1F (ORCPT ); Sun, 13 Dec 2015 15:27:05 -0500 Subject: Re: [PATCH linux-next (v3) 3/3] mtd: part: Add BCM962368 CFE partitioning support To: Jonas Gorski References: <566B460F.1040603@simon.arlott.org.uk> <566B47D9.8020105@simon.arlott.org.uk> Cc: David Woodhouse , Brian Norris , Florian Fainelli , Ralf Baechle , Kevin Cernekee , Linux Kernel Mailing List , MTD Maling List , bcm-kernel-feedback-list , MIPS Mailing List , linux-api@vger.kernel.org From: Simon Arlott Message-ID: <566DD491.4030902@simon.arlott.org.uk> Date: Sun, 13 Dec 2015 20:26:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1002 Lines: 24 On 11/12/15 23:12, Jonas Gorski wrote: > On Fri, Dec 11, 2015 at 11:02 PM, Simon Arlott wrote: >> +#define BCM63XX_CFE_MAGIC_OFFSET 0x4e0 >> +#define BCM963XX_CFE_VERSION_OFFSET 0x570 >> +#define BCM963XX_NVRAM_OFFSET 0x580 > > You should decide whether you want to call it BCM63XX (the SoC) or > BCM963XX (the Board using the SoC). Also probably better served in > bcm963xx_nvram.h I'm going to name the CFE locations, nvram and anything that is a property of the flash layout BCM963XX_*, as a theoretical board using BCM63XX with no flash wouldn't use these. The parser is still called bcm63xxpart so that's currently an anomaly. I'm working on making it support both NOR and NAND flash layouts. -- Simon Arlott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/