Message-ID: <1450039741.20678.7.camel@perches.com>
Subject: Re: [PATCH] checkpatch: detect leading * in NULL comparison check
From: Joe Perches <joe@perches.com>
To: "S. Gilles" <sgilles@math.umd.edu>, Andy Whitcroft <apw@canonical.com>,
        linux-kernel@vger.kernel.org
Date: Sun, 13 Dec 2015 12:49:01 -0800
In-Reply-To: <1450029592-476-1-git-send-email-sgilles@math.umd.edu>
References: <1450029592-476-1-git-send-email-sgilles@math.umd.edu>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 808
Lines: 25

On Sun, 2015-12-13 at 12:59 -0500, S. Gilles wrote:
> Prevent checkpatch.pl from emitting messages like
> 
> ? CHECK: Comparison to NULL could be written "!rx_p"
> ? #51: FILE: drivers/staging/iio/accel/sca3000_ring.c:51:
> ? +???????if (*rx_p == NULL) {
> 
> by checking for leading * characters in the comparison value.
> 
> Signed-off-by: S. Gilles <sgilles@math.umd.edu>
> ---
> 
> I've run this through everything in staging/ as a test, it seems to
> work okay.

This wouldn't work with

	* foo == NULL;

but there don't seem to be any in the kernel source.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/