Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751422AbbLMVwQ (ORCPT ); Sun, 13 Dec 2015 16:52:16 -0500 Received: from mail-lf0-f53.google.com ([209.85.215.53]:34124 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750924AbbLMVwO (ORCPT ); Sun, 13 Dec 2015 16:52:14 -0500 MIME-Version: 1.0 In-Reply-To: <20151213210719.GC19456@lukather> References: <1449873940-10167-1-git-send-email-mweseloh42@gmail.com> <20151213210719.GC19456@lukather> Date: Sun, 13 Dec 2015 22:52:12 +0100 Message-ID: Subject: Re: [PATCH v2] spi: dts: sun4i: Add support for inter-word wait cycles using the SPI Wait Clock Register From: Marcus Weseloh To: Maxime Ripard Cc: linux-sunxi , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Chen-Yu Tsai , Mark Brown , devicetree , "Mailing List, Arm" , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1446 Lines: 31 2015-12-13 22:07 GMT+01:00 Maxime Ripard : [...] >> There is one review comment that I didn't address: Rob Herring suggested >> that this should be in the core-binding rather than in sun4i. I checked >> many of the hardware manuals of other SPI drivers and it looks to me like >> this hardware based inter-word delay is a feature that not many SPI >> controllers offer. And the SPI core currently has no way to control an >> inter-word delay, only inter-message. So I would like to propose this again >> as a sun4i binding, as it targets a sun4i (or sunxi?) specific hardware >> feature. > > Only a few of them justify to have this in the framework. There's a > bunch of controllers that support such a feature, and it definitely > belongs in the core. > > The point of the framework is not to be the least common denominator, > it's about having as much code in common as possible, and it > definitely falls into that category. Ok, now I understand. I did indeed think that the SPI core is more like a least common denominator. So I will add the property to the spi-core binding, as initially requested by Rob and send a v3. Thanks for the review, Maxime! Marcus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/