From: "S. Gilles" <sgilles@math.umd.edu>
Date: Sun, 13 Dec 2015 17:02:54 -0500
To: Joe Perches <joe@perches.com>
Cc: "S. Gilles" <sgilles@math.umd.edu>, Andy Whitcroft <apw@canonical.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: detect leading * in NULL comparison check
Message-ID: <20151213220254.GA26291@number16>
References: <1450029592-476-1-git-send-email-sgilles@math.umd.edu>
 <1450039741.20678.7.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1450039741.20678.7.camel@perches.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1116
Lines: 37

On 2015-12-13T12:49:01, Joe Perches wrote:
> On Sun, 2015-12-13 at 12:59 -0500, S. Gilles wrote:
> > Prevent checkpatch.pl from emitting messages like
> > 
> >   CHECK: Comparison to NULL could be written "!rx_p"
> >   #51: FILE: drivers/staging/iio/accel/sca3000_ring.c:51:
> >   +       if (*rx_p == NULL) {
> > 
> > by checking for leading * characters in the comparison value.
> > 
> > Signed-off-by: S. Gilles <sgilles@math.umd.edu>
> > ---
> > 
> > I've run this through everything in staging/ as a test, it seems to
> > work okay.
> 
> This wouldn't work with
> 
> 	* foo == NULL;
> 
> but there don't seem to be any in the kernel source.

Some other stuff like

	*(foo) == NULL

won't be caught as well, but in such false negative cases, other style
conventions would have to be violated anyway. I'm not sure how strong
that argument is.

-- 
S. Gilles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/