Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751753AbbLMXRO (ORCPT ); Sun, 13 Dec 2015 18:17:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38565 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbbLMXRN (ORCPT ); Sun, 13 Dec 2015 18:17:13 -0500 Date: Mon, 14 Dec 2015 00:17:04 +0100 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , LKML , David Ahern , Frederic Weisbecker , Andi Kleen , Stephane Eranian , Adrian Hunter Subject: Re: [PATCH/RFC 08/16] perf tools: Export a couple of hist functions Message-ID: <20151213231703.GB19257@krava.local> References: <1449734015-9148-1-git-send-email-namhyung@kernel.org> <1449734015-9148-9-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449734015-9148-9-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1891 Lines: 57 On Thu, Dec 10, 2015 at 04:53:27PM +0900, Namhyung Kim wrote: > These are necessary for multi threaded sample processing: > > - hists__get__get_rotate_entries_in() > - hists__collapse_insert_entry() > - __hists__init() > > Signed-off-by: Namhyung Kim > --- > tools/perf/util/hist.c | 19 ++++++++++++------- > tools/perf/util/hist.h | 5 +++++ > 2 files changed, 17 insertions(+), 7 deletions(-) > > diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c > index d534ed76164b..ea4f3ad978b0 100644 > --- a/tools/perf/util/hist.c > +++ b/tools/perf/util/hist.c > @@ -972,9 +972,8 @@ void hist_entry__delete(struct hist_entry *he) > * collapse the histogram > */ > > -static bool hists__collapse_insert_entry(struct hists *hists __maybe_unused, > - struct rb_root *root, > - struct hist_entry *he) > +bool hists__collapse_insert_entry(struct hists *hists __maybe_unused, > + struct rb_root *root, struct hist_entry *he) > { > struct rb_node **p = &root->rb_node; > struct rb_node *parent = NULL; > @@ -1014,7 +1013,7 @@ static bool hists__collapse_insert_entry(struct hists *hists __maybe_unused, > return true; > } > > -static struct rb_root *hists__get_rotate_entries_in(struct hists *hists) > +struct rb_root *hists__get_rotate_entries_in(struct hists *hists) > { > struct rb_root *root; > > @@ -1549,10 +1548,8 @@ int perf_hist_config(const char *var, const char *value) > return 0; > } > > -static int hists_evsel__init(struct perf_evsel *evsel) > +int __hists__init(struct hists *hists) and this one also ;-) Acked-by: Jiri Olsa thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/