Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752132AbbLNCDR (ORCPT ); Sun, 13 Dec 2015 21:03:17 -0500 Received: from mail-io0-f172.google.com ([209.85.223.172]:34188 "EHLO mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751814AbbLNCDQ (ORCPT ); Sun, 13 Dec 2015 21:03:16 -0500 MIME-Version: 1.0 In-Reply-To: <20151214014405.GB9568@danjae.kornet> References: <1449734015-9148-1-git-send-email-namhyung@kernel.org> <1449734015-9148-4-git-send-email-namhyung@kernel.org> <20151210190748.GJ17996@kernel.org> <20151214014405.GB9568@danjae.kornet> From: Namhyung Kim Date: Mon, 14 Dec 2015 11:02:55 +0900 X-Google-Sender-Auth: vOsPdqwTF_CJs3ut57srsbMapyU Message-ID: Subject: Re: [PATCH/RFC 03/16] perf top: Factor out warnings about kernel addresses and symbols To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Frederic Weisbecker , Andi Kleen , Stephane Eranian , Adrian Hunter Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1608 Lines: 45 On Mon, Dec 14, 2015 at 10:44 AM, Namhyung Kim wrote: > Hi Arnaldo, > > On Thu, Dec 10, 2015 at 04:07:48PM -0300, Arnaldo Carvalho de Melo wrote: >> Em Thu, Dec 10, 2015 at 04:53:22PM +0900, Namhyung Kim escreveu: >> > Factor out warning messages into separate functions. These will be >> > called in the display thread later. >> > >> > Signed-off-by: Namhyung Kim >> > --- >> > tools/perf/builtin-top.c | 95 ++++++++++++++++++++++++++---------------------- >> > 1 file changed, 51 insertions(+), 44 deletions(-) >> >> Without applying patch 2, will check if it happens without this patch as well >> >> >> >> [root@ssdandy ~]# echo 2 > /proc/sys/kernel/kptr_restrict >> [root@ssdandy ~]# perf top >> perf: Segmentation fault >> -------- backtrace -------- >> perf[0x538b3b] >> /lib64/libc.so.6(+0x35650)[0x7f401c036650] >> perf[0x43af66] >> perf(cmd_top+0xedf)[0x43cdbf] >> perf[0x47b7c3] >> perf(main+0x617)[0x4222b7] >> /lib64/libc.so.6(__libc_start_main+0xf5)[0x7f401c022af5] >> perf[0x4223c9] >> [0x0] >> [root@ssdandy ~]# > > This patch changed the order in the condition, so if kptr_restrict is > on, kernel map is NULL and checking al->map->dso caused the segfault. Oh, it's not this patch. This patch just move the condition as is but I did the change in the patch 5/16. Will fix there. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/