Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752107AbbLNCH1 (ORCPT ); Sun, 13 Dec 2015 21:07:27 -0500 Received: from mail-lb0-f182.google.com ([209.85.217.182]:34267 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751708AbbLNCHY (ORCPT ); Sun, 13 Dec 2015 21:07:24 -0500 MIME-Version: 1.0 In-Reply-To: <260ee0c6c9481ceae79b967a95b5e9fe76c2eabc.1450036445.git.jerry.hoemann@hpe.com> References: <260ee0c6c9481ceae79b967a95b5e9fe76c2eabc.1450036445.git.jerry.hoemann@hpe.com> Date: Mon, 14 Dec 2015 03:07:22 +0100 X-Google-Sender-Auth: O11blFe3ATsLSGoXR-OtyKp8F8Y Message-ID: Subject: Re: [PATCH v3 1/6] acpica: Correct parameter type to acpi_evaluate_dsm From: "Rafael J. Wysocki" To: Jerry Hoemann Cc: Ross Zwisler , "Rafael J. Wysocki" , Len Brown , Dan Williams , elliott@hpe.com, jmoyer , krivenok.dmitry@gmail.com, linda.knippers@hpe.com, Robert Moore , Lv , Rafael Wysocki , linux-nvdimm@ml01.01.org, ACPI Devel Maling List , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 992 Lines: 26 On Mon, Dec 14, 2015 at 2:54 AM, Jerry Hoemann wrote: > The ACPI spec speicifies that arguments "Revision ID" and > "Function Index" to a _DSM are type "Integer." Type Integers > are 64 bit quantities. > > The function evaluate_dsm specifies these types as simple "int" > which are 32 bits. Correct type passed to acpi_evaluate_dsm > and its callers and derived callers to pass correct type. > > acpi_check_dsm and acpi_evaluate_dsm_typed had similar issue > and were corrected as well. > > Signed-off-by: Jerry Hoemann The changes look OK to me, but this is not ACPICA material. Please change the subject to something like "ACPI / utils: Fix acpi_evaluate_dsm() argument type". Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/