Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752824AbbLNJLD (ORCPT ); Mon, 14 Dec 2015 04:11:03 -0500 Received: from mail-oi0-f48.google.com ([209.85.218.48]:33498 "EHLO mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783AbbLNJK6 (ORCPT ); Mon, 14 Dec 2015 04:10:58 -0500 MIME-Version: 1.0 In-Reply-To: <20151214003621.GB718@swordfish> References: <566ABCD9.1060404@users.sourceforge.net> <566B13C1.50907@users.sourceforge.net> <566B1542.7040902@users.sourceforge.net> <20151214003621.GB718@swordfish> Date: Mon, 14 Dec 2015 10:10:57 +0100 X-Google-Sender-Auth: Ro8c49d7f3jZ4DpSEGnO09H5DY0 Message-ID: Subject: Re: [PATCH 2/2] z2ram: Delete a jump label in z2_init() From: Geert Uytterhoeven To: Sergey Senozhatsky Cc: SF Markus Elfring , LKML , Minchan Kim , Nitin Gupta , "kernel-janitors@vger.kernel.org" , Julia Lawall , Andrew Morton , Jens Axboe , "Linux/m68k" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1956 Lines: 66 On Mon, Dec 14, 2015 at 1:36 AM, Sergey Senozhatsky wrote: > Cc Jens, Andrew, Geert > > On (12/11/15 19:26), SF Markus Elfring wrote: >> >> This issue was detected by using the Coccinelle software. >> >> * Let us return directly if a call of the function "register_blkdev" failed. >> >> * Remove the jump label "err" then. >> >> Signed-off-by: Markus Elfring Acked-by: Geert Uytterhoeven >> --- >> drivers/block/z2ram.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c >> index 968f9e5..b07581d 100644 >> --- a/drivers/block/z2ram.c >> +++ b/drivers/block/z2ram.c >> @@ -345,9 +345,8 @@ z2_init(void) >> if (!MACH_IS_AMIGA) >> return -ENODEV; >> >> - ret = -EBUSY; >> if (register_blkdev(Z2RAM_MAJOR, DEVICE_NAME)) >> - goto err; >> + return -EBUSY; >> >> ret = -ENOMEM; >> z2ram_gendisk = alloc_disk(1); >> @@ -374,7 +373,6 @@ out_queue: >> put_disk(z2ram_gendisk); >> out_disk: >> unregister_blkdev(Z2RAM_MAJOR, DEVICE_NAME); >> -err: >> return ret; >> } > > z2ram and zram are different drivers, but the change looks > ok to me. > > z2ram can be improved in many ways, so my question is - do > people still use it? I think it's still used. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/