Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932179AbbLNKAt (ORCPT ); Mon, 14 Dec 2015 05:00:49 -0500 Received: from ozlabs.org ([103.22.144.67]:56341 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752691AbbLNKAs (ORCPT ); Mon, 14 Dec 2015 05:00:48 -0500 Message-ID: <1450087241.9595.0.camel@ellerman.id.au> Subject: Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs From: Michael Ellerman To: Steven Rostedt , Benjamin Herrenschmidt Cc: Denis Kirjanov , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org Date: Mon, 14 Dec 2015 21:00:41 +1100 In-Reply-To: <20151207163343.0ea2f1bb@gandalf.local.home> References: <1448389419-5296-1-git-send-email-kda@linux-powerpc.org> <1448389419-5296-2-git-send-email-kda@linux-powerpc.org> <20151207155224.2a8d71dd@gandalf.local.home> <1449522135.21036.11.camel@kernel.crashing.org> <20151207163343.0ea2f1bb@gandalf.local.home> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 822 Lines: 23 On Mon, 2015-12-07 at 16:33 -0500, Steven Rostedt wrote: > On Tue, 08 Dec 2015 08:02:15 +1100 > Benjamin Herrenschmidt wrote: > > On Mon, 2015-12-07 at 15:52 -0500, Steven Rostedt wrote: > > > > + TP_CONDITION(cpu_online(smp_processor_id())), > > > > + > > > > This should probably be some kind of __raw version though, hcalls can > > be called in contexts where the debug stuff in smp_processor_id() isn't > > safe (or preempt enabled). > > > > OK, then that needs to be updated. Denis, please respin with raw_smp_processor_id(). cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/