Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932212AbbLNKCY (ORCPT ); Mon, 14 Dec 2015 05:02:24 -0500 Received: from mail-pf0-f178.google.com ([209.85.192.178]:34874 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932135AbbLNKCU (ORCPT ); Mon, 14 Dec 2015 05:02:20 -0500 Date: Mon, 14 Dec 2015 19:03:23 +0900 From: Sergey Senozhatsky To: SF Markus Elfring Cc: Sergey Senozhatsky , LKML , Minchan Kim , Nitin Gupta , kernel-janitors@vger.kernel.org, Julia Lawall , Andrew Morton Subject: Re: [PATCH 1/2] zram: Less checks in zram_bvec_write() after error detection Message-ID: <20151214100323.GA16372@swordfish> References: <566ABCD9.1060404@users.sourceforge.net> <566B13C1.50907@users.sourceforge.net> <566B14DA.1080709@users.sourceforge.net> <20151214002702.GA718@swordfish> <566E6895.5050603@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <566E6895.5050603@users.sourceforge.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 736 Lines: 29 On (12/14/15 07:58), SF Markus Elfring wrote: [..] > > keep it the way it is please. > > I suggest to make the affected exception handling a bit more efficient. > Such source code fine-tuning has got a few special consequences. by 'more efficient' you mean saving cpu cycles on 'bvec->bv_len != PAGE_SIZE' comparison in exception/error path? ... check_strm: if (zstrm) zcomp_strm_release(zram->comp, zstrm); if (is_partial_io(bvec)) { free_uncmem: kfree(uncmem); } ... no. -ss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/