Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932308AbbLNKHv (ORCPT ); Mon, 14 Dec 2015 05:07:51 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:11189 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932226AbbLNKHs (ORCPT ); Mon, 14 Dec 2015 05:07:48 -0500 X-AuditID: cbfec7f4-f79026d00000418a-74-566e94f1b323 From: Andrzej Hajda To: =?UTF-8?q?Emilio=20L=C3=B3pez?= Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Michael Turquette , Stephen Boyd , Maxime Ripard , Chen-Yu Tsai , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] clk: sunxi: fix handling return value of of_property_match_string Date: Mon, 14 Dec 2015 11:06:00 +0100 Message-id: <1450087564-28441-3-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1450087564-28441-1-git-send-email-a.hajda@samsung.com> References: <1450087564-28441-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPLMWRmVeSWpSXmKPExsVy+t/xy7ofp+SFGXx/YGRxa905VouNM9az Wjzb8IXFYtPja6wWH3vusVpc3jWHzWLtkbvsFls37WW2uHjK1eLHmW4Wi5+HzjM5cHu8v9HK 7nG5r5fJY8Oj1awef965ezzZdJHRY/OSeo++LasYPT5vkgvgiOKySUnNySxLLdK3S+DKmLSi qOAsZ8XPJftZGxibOLoYOTkkBEwktvTeZoSwxSQu3FvPBmILCSxllHjSa9LFyAVkNzFJXJu6 DizBJqAp8XfzTTBbRMBK4tziNcwgNrPATGaJFy3qILawQIjE9QPH2UFsFgFVie0Lj7F2MXJw 8Ao4S1w/qgKxS07i5LHJYGFOAReJmRuLQUwhoIpbf6MmMPIuYGRYxSiaWppcUJyUnmuoV5yY W1yal66XnJ+7iRESjF92MC4+ZnWIUYCDUYmHN2NZbpgQa2JZcWXuIUYJDmYlEd4Eq7wwId6U xMqq1KL8+KLSnNTiQ4zSHCxK4rxzd70PERJITyxJzU5NLUgtgskycXBKNTCWf8zklnxXum3u mq/n70VdEC48ybTun2aFG6snn9bjkgeHxefuXc5xpPi2c/ffizpefixGAoecfU6ssTTxUo20 nRDxLeGKvO9lPe8ahiVvvoUveTY/PdX/Zpr8pRNnUy+K+01xe3zZOXDl5oqLb/l5luc1TRYI nMojfmFjZHk752umPaGafVeUWIozEg21mIuKEwEZ+CAIQgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1437 Lines: 42 The function can return negative values, so its result should be assigned to signed variable. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- drivers/clk/sunxi/clk-sun8i-bus-gates.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/sunxi/clk-sun8i-bus-gates.c b/drivers/clk/sunxi/clk-sun8i-bus-gates.c index 7ab60c5..ecadd97 100644 --- a/drivers/clk/sunxi/clk-sun8i-bus-gates.c +++ b/drivers/clk/sunxi/clk-sun8i-bus-gates.c @@ -47,12 +47,12 @@ static void __init sun8i_h3_bus_gates_init(struct device_node *node) return; for (i = 0; i < ARRAY_SIZE(names); i++) { - index = of_property_match_string(node, "clock-names", - names[i]); - if (index < 0) + int idx = of_property_match_string(node, "clock-names", + names[i]); + if (idx < 0) return; - parents[i] = of_clk_get_parent_name(node, index); + parents[i] = of_clk_get_parent_name(node, idx); } clk_data = kmalloc(sizeof(struct clk_onecell_data), GFP_KERNEL); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/