Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932366AbbLNKIL (ORCPT ); Mon, 14 Dec 2015 05:08:11 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:13956 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932220AbbLNKID (ORCPT ); Mon, 14 Dec 2015 05:08:03 -0500 X-AuditID: cbfec7f4-f79026d00000418a-be-566e9501a6f9 From: Andrzej Hajda To: Jayamohan Kallickal , Ketan Mukadam , John Soni Jose Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] be2iscsi: fix handling return value of mgmt_open_connection Date: Mon, 14 Dec 2015 11:06:04 +0100 Message-id: <1450087564-28441-7-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1450087564-28441-1-git-send-email-a.hajda@samsung.com> References: <1450087564-28441-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMLMWRmVeSWpSXmKPExsVy+t/xy7qMU/PCDDo/iVvcWneO1WLjjPWs Fg/u/mW1+L/+NovFqi//WCwu75rDZtF9fQebxdojd9ktlh//x2Sx/OVSdgcuj2XnJzJ7HP7x g9nj49NbLB59W1YxenzeJBfAGsVlk5Kak1mWWqRvl8CV8ePoX8aCtRwVO19uZG9g7GXvYuTk kBAwkZj75hUThC0mceHeerYuRi4OIYGljBLf18yCcpqYJNY/nMYKUsUmoCnxd/NNsISIwDRG iRVzpjKBOMwC65kktp3eD1YlLOAjsWPua2YQm0VAVeL9mvtgO3gFnCUeftnABrFPTuLksclA 9RwcnAIuEjM3FoOYQkAlt/5GTWDkXcDIsIpRNLU0uaA4KT3XUK84Mbe4NC9dLzk/dxMjJOi+ 7GBcfMzqEKMAB6MSD2/GstwwIdbEsuLK3EOMEhzMSiK8CVZ5YUK8KYmVValF+fFFpTmpxYcY pTlYlMR55+56HyIkkJ5YkpqdmlqQWgSTZeLglGpgXOj+judXVu9v9kNr0iW07TRnzZ9yUOGq 0m532WOfnV73Jf+o+OJTcdJQtrAr1fni+/Oru3fUxif1nuj8fH+C8Mlc9f1FdkahDyTqW6sf nzxy/63bszd8VrqmM2svufYKfSzr2ViSq5EXzfXjwKpn26cs5c9apvFE7IXgectT67PPM69L zo6rUWIpzkg01GIuKk4EAKPoqg02AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1283 Lines: 36 The function can return negative values, so its result should be assigned to signed variable. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- drivers/scsi/be2iscsi/be_iscsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_iscsi.c b/drivers/scsi/be2iscsi/be_iscsi.c index b7087ba..ce9f192 100644 --- a/drivers/scsi/be2iscsi/be_iscsi.c +++ b/drivers/scsi/be2iscsi/be_iscsi.c @@ -1106,8 +1106,8 @@ static int beiscsi_open_conn(struct iscsi_endpoint *ep, struct beiscsi_hba *phba = beiscsi_ep->phba; struct tcp_connect_and_offload_out *ptcpcnct_out; struct be_dma_mem nonemb_cmd; - unsigned int tag, req_memsize; - int ret = -ENOMEM; + unsigned int req_memsize; + int tag, ret = -ENOMEM; beiscsi_log(phba, KERN_INFO, BEISCSI_LOG_CONFIG, "BS_%d : In beiscsi_open_conn\n"); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/