Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932246AbbLNK2O (ORCPT ); Mon, 14 Dec 2015 05:28:14 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:65386 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932138AbbLNK2L (ORCPT ); Mon, 14 Dec 2015 05:28:11 -0500 From: Arnd Bergmann To: Thierry Reding Cc: Ley Foon Tan , Geert Uytterhoeven , Paul Gortmaker , "linux-kernel@vger.kernel.org" , Linux-sh list , linux-pci , Alexandre Courbot , Pratyush Anand , Michal Simek , Kishon Vijay Abraham I , Murali Karicheri , =?ISO-8859-1?Q?S=F6ren?= Brinkmann , Jason Cooper , Stephen Warren , Simon Horman , linux-tegra@vger.kernel.org, "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Thomas Petazzoni , Richard Zhu , Rocketboard Maillist , Bjorn Helgaas , Lucas Stach Subject: Re: [PATCH 00/10] drivers/pci: avoid module_init in non-modular host/pci* Date: Mon, 14 Dec 2015 11:27:02 +0100 Message-ID: <3302340.SIljl1qYTl@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151214091940.GA15126@ulmo.nvidia.com> References: <1449970917-12633-1-git-send-email-paul.gortmaker@windriver.com> <20151214091940.GA15126@ulmo.nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:V3v6BwtF/oNSuupsOHYwXOWPiVqwdD9leDTCnrEajJDD7JTuBkU c6O/NGQUTWgjo7MIcWXVXwu/H5cEDJZkMu8DF0G4Z6W0omyI7nPxL7P8puMVqKdgZPsDICx i7NM+3Y1C25tDFaByqMSP5/sCjziyi9Txjv8nkdDEygsulph0KE59VSOxJWd4wmbGmNioc3 0ZP/6RyWx+4ITSWG0Hh6A== X-UI-Out-Filterresults: notjunk:1;V01:K0:DiJ50KQ2VNs=:sOza+Oq2SQZlILc5kcJkRF kG6TMuEmMEqmR7AdK6G6m4stxMl0vIzqYDmjCE3UK0ovWBJRXmNWN4YW793qNaAWTK5PFkHAX 6hpBWE5lfhy3xW5K/IZfvmi6Z6WcmwkxqcnZWNCE339m5+E9n08jpHRw8HgVp1/iNmg/ai4cl fHQ3HzJwcBk+CQiIMG8CencYaOkAJmimNIBNwKCMFlNM+JwOMJHLCfad6xtnvvfjraofH4big NIO8+NCaaNjy1Sw58ipjy16ImS2LqShIKXYDGcuTwLjNYsmI3xsEV5sQCKfh4nRqx105/+XbX WEalAnzRQNrK+fL/Kpc34nZgrq8hDjcZMGLb2tEet/XWM8CCJWx0Uyz8DzGXySi6fOBEmiVAH ivabBMJCh3EJrDAr5PO1Z7CbtVqFBYI5u4uJvqPFCxt/LD+SiYh/bDmj9gt3Ia1K4sxwj7Wiu /gK2MLM8cTwUDj8rKaHwjfvCQ6n/NEaJd9LZzDanAb3IgWfHyFG4apVhOcZE02rwDzeWiBOm5 3dZSYmchtqjvVQNeUDluT2rFGDW915hvG0rOxbvdmRbReMmr5gtZahVGWWkBfC17b4QfYAuif WoB4A14kPJIyK4t++2JMiQbAMbikE3qe9T2H92+UemXwREV6shfGMM/nTe8kZsFvAvqAtzkDS uNQ2LHndcywTyUnZcuLpp7vc13ugq1PRZr+jAo7BjZQy+BWa88pVSuAInHIunv6s1GT+m/rDb 3S+wZdwuGG3QTGTU Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1194 Lines: 27 On Monday 14 December 2015 10:19:40 Thierry Reding wrote: > > PCIe host driver that use fixup (DECLARE_PCI_FIXUP_*) can't use tristate. > > Fixup region is in kernel region and this region if not updated when > > loading a module. > > Interesting, I hadn't thought about that. I suppose this means that the > module will end up containing an unused section with the fixup code. It > might be useful to add a way for that to trigger a warning at build > time. > > Perhaps to fix this a mechanism could be introduced to add a table of > fixups to a host controller driver and that will get applied to all > children of the bridge. It could be problematic to cover all of the > different fixup stages, though. > I think a lot of the fixups shouldn't really be there in the first place, they are about stuff that we can fix up in the probe function, or that should be fixed up in the probe function with some appropriate core support added. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/