Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932308AbbLNK2z (ORCPT ); Mon, 14 Dec 2015 05:28:55 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:33387 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932275AbbLNK2v (ORCPT ); Mon, 14 Dec 2015 05:28:51 -0500 Subject: Re: [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable To: Russell King - ARM Linux , Andrew Morton References: <1449667265-17525-1-git-send-email-pmladek@suse.com> <1449667265-17525-5-git-send-email-pmladek@suse.com> <20151211124159.GB3729@pathway.suse.cz> <20151211145725.b0e81bb4bb18fcd72ef5f557@linux-foundation.org> <20151211232113.GZ8644@n2100.arm.linux.org.uk> Cc: Petr Mladek , Geert Uytterhoeven , Peter Zijlstra , Steven Rostedt , Jiri Kosina , Ingo Molnar , Thomas Gleixner , "linux-kernel@vger.kernel.org" , the arch/x86 maintainers , "linux-arm-kernel@lists.infradead.org" , "adi-buildroot-devel@lists.sourceforge.net" , Cris , Linux MIPS Mailing List , "linuxppc-dev@lists.ozlabs.org" , linux-s390 , Linux-sh list , sparclinux From: Daniel Thompson Message-ID: <566E99DF.6050008@linaro.org> Date: Mon, 14 Dec 2015 10:28:47 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151211232113.GZ8644@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2046 Lines: 41 On 11/12/15 23:21, Russell King - ARM Linux wrote: > As I explained when I did that work, the vast majority of ARM platforms > are unable to trigger anything like a NMI - the FIQ is something that's > generally a property of the secure monitor, and is not accessible to > Linux. However, there are platforms where it is accessible. > > The work to add the FIQ-based variant never happened (I've no idea what > happened to that part, Daniel seems to have lost interest in working on > it.) So, what we have is the IRQ-based variant merged in mainline, which > would be the fallback for the "FIQ not available" cases, and I carry a > local hack in my tree which provides the FIQ-based version - but if it > were to trigger, it takes out all interrupts (hence why I've not merged > my hack.) > > I think the reason that the FIQ-based variant has never really happened > is that hooking into the interrupt controller code to clear down the FIQ > creates such a horrid layering violation, and also a locking mess that > I suspect it's just been given up with. I haven't quite given up; I'm still looking into this stuff. However you're certainly right that connecting the FIQ handler to the GIC code in an elegant way is tough. I've been working in parallel on an arm64 implementation with the result that I'm now two lumps of code that are almost, but not quite, ready. Right now I hope to share latest arm code fairly late in the this devcycle (for review rather than merge) followed up with a new version very early in v4.6. Even now I think the code needs a long soak in -next just in case there are any lurking regressions on particular platforms. I don't expect anyone to base decisions on my aspirations above but would like to reassure Russell that I haven't given up on it. Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/