Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932338AbbLNKar (ORCPT ); Mon, 14 Dec 2015 05:30:47 -0500 Received: from mail-io0-f180.google.com ([209.85.223.180]:35565 "EHLO mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932140AbbLNKao (ORCPT ); Mon, 14 Dec 2015 05:30:44 -0500 MIME-Version: 1.0 In-Reply-To: <1450087564-28441-6-git-send-email-a.hajda@samsung.com> References: <1450087564-28441-1-git-send-email-a.hajda@samsung.com> <1450087564-28441-6-git-send-email-a.hajda@samsung.com> Date: Mon, 14 Dec 2015 19:30:44 +0900 X-Google-Sender-Auth: s1HvyQRuRwF2guIBW8WxaVSMpw0 Message-ID: Subject: Re: [PATCH] extcon: max77843: fix handling return value of regmap_irq_get_virq From: Krzysztof Kozlowski To: Andrzej Hajda Cc: MyungJoo Ham , Chanwoo Choi , Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 838 Lines: 24 2015-12-14 19:06 GMT+09:00 Andrzej Hajda : > The function can return negative values, so its result should > be assigned to signed variable. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 > > Signed-off-by: Andrzej Hajda > --- > drivers/extcon/extcon-max77843.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/