Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932354AbbLNKbp (ORCPT ); Mon, 14 Dec 2015 05:31:45 -0500 Received: from mail-ig0-f177.google.com ([209.85.213.177]:34705 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932162AbbLNKbn (ORCPT ); Mon, 14 Dec 2015 05:31:43 -0500 MIME-Version: 1.0 In-Reply-To: <1450087564-28441-5-git-send-email-a.hajda@samsung.com> References: <1450087564-28441-1-git-send-email-a.hajda@samsung.com> <1450087564-28441-5-git-send-email-a.hajda@samsung.com> Date: Mon, 14 Dec 2015 19:31:42 +0900 X-Google-Sender-Auth: GKQO8EapKMWpWrxJlHUHxuIJWpk Message-ID: Subject: Re: [PATCH] extcon: max14577: fix handling return value of regmap_irq_get_virq From: Krzysztof Kozlowski To: Andrzej Hajda Cc: Chanwoo Choi , Bartlomiej Zolnierkiewicz , Marek Szyprowski , MyungJoo Ham , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 873 Lines: 26 2015-12-14 19:06 GMT+09:00 Andrzej Hajda : > The function can return negative values, so its result should > be assigned to signed variable. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 > > Signed-off-by: Andrzej Hajda > --- > drivers/extcon/extcon-max14577.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski Do you plan to fix also max77693? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/