Date: Mon, 14 Dec 2015 11:37:39 +0100
From: Sascha Hauer <s.hauer@pengutronix.de>
To: linux-pm@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
        Eduardo Valentin <edubezval@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
        Matthias Brugger <matthias.bgg@gmail.com>,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de
Subject: Re: [PATCH v12] Add Mediatek thermal support
Message-ID: <20151214103739.GA14356@pengutronix.de>
References: <1448883753-19068-1-git-send-email-s.hauer@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1448883753-19068-1-git-send-email-s.hauer@pengutronix.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 4141
Lines: 131

Eduardo,

Ok, to apply this? There seem to be no further comments.

Sascha

On Mon, Nov 30, 2015 at 12:42:30PM +0100, Sascha Hauer wrote:
> This series adds support for the thermal sensors included in the
> MT8173 SoC. Currently only basic temperature reading is supported
> without any interrupt support.
> 
> The cpufreq driver for MT8173 is currently under review, so there's no
> real cooling device available in mainline. Until this is available the
> thermal driver can be tested with the following dts snippet. It creates
> a fake gpio fan and a fake trip point which is so low that it can easily
> be reached with a "cat /dev/zero > /dev/null" on the command line.
> 
> Sascha
> 
> Changes since v11:
> - Fix usage of uninitialized variable gcc didn't warn about
> 
> changes since v10:
> - Some style cleanup
> - Add comment to make clear why we use the sensors in banks even if we
>   currently only use the maximum of all banks
> 
> changes since v9:
> - rebase on v4.3
> - Add support for reading the calibration values from nvmem fuses
> - Only register a single thermal zone instead of four as it seems
>   that's everything needed
> 
> changes since v8:
> - Add commit description to binding patch
> - rebase on v4.3-rc2
> 
> changes since v7:
> - re-add some used defines removed in v5
> - Use MT8173_THERMAL_ZONE_* defines as array indices in static initializers
> 
> changes since v6:
> - remove dot in Hanyi Wus name
> 
> changes since v5:
> - update copyright
> - remove unused defines
> 
> Changes since v4:
> - give calibration constants more meaningful names (offset, slope)
> - Use define instead of 0x00c for register access.
> 
> Changes since v3:
> - add include/dt-bindings/thermal/mt8173.h for to be able to use sensor names
>   in dts files
> - fix disabling wrong clock in error path
> - remove now unused reset-names property from binding document
> - rename MT8173_NUM_BANKS -> MT8173_NUM_ZONES
> - rename MT8173_NUM_SENSING_POINTS -> MT8173_NUM_SENSORS_PER_ZONE
> - rename struct thermal_zone_device *tz -> struct thermal_zone_device *tzd
> 
> Changes since v2:
> - sort #includes alphabetically
> - Add prefix to register defines
> - drop some members from struct mtk_thermal
> - simplify raw_to_mcelsius()
> - add and use more register bit defines
> - use device_reset() instead of devm_reset_control_get()/reset_control_reset()
> - misc other stuff
> 
> Changes since v1:
> - Use "mediatek," prefix for custom properties
> - Drop "thermal: consistently use int for temperatures" dependency
> 
> -------------
> 
> 	fan: gpio_fan {
> 		compatible = "gpio-fan";
> 		gpios = <&pio 24 0>;
> 		gpio-fan,speed-map = <0    0
> 				      4500 1>;
> 		#cooling-cells = <2>;
> 	};
> 
> 	thermal-zones {
> 			cpu_thermal: cpu_thermal {
> 			polling-delay-passive = <1000>; /* milliseconds */
> 			polling-delay = <1000>; /* milliseconds */
> 
> 			thermal-sensors = <&thermal>;
> 
> 			trips {
> 				cpu_passive: cpu_passive {
> 					temperature = <47000>; /* millicelsius */
> 					hysteresis = <2000>; /* millicelsius */
> 					type = "passive";
> 				};
> 
> 				cpu_crit {
> 					temperature = <90000>; /* millicelsius */
> 					hysteresis = <2000>; /* millicelsius */
> 					type = "critical";
> 				};
> 			};
> 
> 			cooling-maps {
> 				map0 {
> 					trip = <&cpu_passive>;
> 					cooling-device = <&fan THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> 				};
> 			};
> 		};
> 	};
> 
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/