Date: Mon, 14 Dec 2015 12:03:58 +0100
From: Jan Kara <jack@suse.cz>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, Jan Kara <jack@suse.com>
Subject: Re: [PATCH 02/10] fs: make quota/netlink.c explicitly non-modular
Message-ID: <20151214110358.GF8474@quack.suse.cz>
References: <1449955812-10149-1-git-send-email-paul.gortmaker@windriver.com>
 <1449955812-10149-3-git-send-email-paul.gortmaker@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1449955812-10149-3-git-send-email-paul.gortmaker@windriver.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1144
Lines: 30

On Sat 12-12-15 16:30:04, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> config QUOTA_NETLINK_INTERFACE
>         bool "Report quota messages through netlink interface"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the couple traces of modularity so that when reading the
> driver there is no doubt it is builtin-only.
> 
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering gets bumped to one level earlier when we
> use the more appropriate fs_initcall here.  However we've made similar
> changes before without any fallout and none is expected here either.
> 
> Cc: Jan Kara <jack@suse.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Looks good. I have taken the patch into my tree.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/