Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932289AbbLNLFS (ORCPT ); Mon, 14 Dec 2015 06:05:18 -0500 Received: from mx2.suse.de ([195.135.220.15]:54115 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932140AbbLNLFQ (ORCPT ); Mon, 14 Dec 2015 06:05:16 -0500 Date: Mon, 14 Dec 2015 12:05:13 +0100 From: Jan Kara To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Jan Kara , Alexander Viro , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 10/10] fs: make quota/dquot.c explicitly non-modular Message-ID: <20151214110513.GG8474@quack.suse.cz> References: <1449955812-10149-1-git-send-email-paul.gortmaker@windriver.com> <1449955812-10149-11-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449955812-10149-11-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1694 Lines: 53 On Sat 12-12-15 16:30:12, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > config QUOTA > bool "Quota support" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the couple traces of modularity so that when reading the > driver there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering gets bumped to one level earlier when we > use the more appropriate fs_initcall here. However we've made similar > changes before without any fallout and none is expected here either. > > We don't delete module.h because the code in turn tries to load other > modules as appropriate and so it still needs that header. Looks good. I have taken the patch to my tree. Honza > > Cc: Jan Kara > Cc: Alexander Viro > Cc: linux-fsdevel@vger.kernel.org > Signed-off-by: Paul Gortmaker > --- > fs/quota/dquot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c > index ef0d64b2a6d9..fbd70af98820 100644 > --- a/fs/quota/dquot.c > +++ b/fs/quota/dquot.c > @@ -2924,4 +2924,4 @@ static int __init dquot_init(void) > > return 0; > } > -module_init(dquot_init); > +fs_initcall(dquot_init); > -- > 2.6.1 > > -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/