Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932381AbbLNLg1 (ORCPT ); Mon, 14 Dec 2015 06:36:27 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:35601 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932206AbbLNLgY (ORCPT ); Mon, 14 Dec 2015 06:36:24 -0500 Subject: Re: [PATCH v2 4/8] dt-bindings: Add a binding for Mediatek Video Encoder To: tiffany lin , Rob Herring References: <1449827743-22895-1-git-send-email-tiffany.lin@mediatek.com> <1449827743-22895-5-git-send-email-tiffany.lin@mediatek.com> <20151211172919.GA2896@rob-hp-laptop> <1450081618.5745.3.camel@mtksdaap41> Cc: daniel.thompson@linaro.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon , Mauro Carvalho Chehab , Daniel Kurtz , Hans Verkuil , Laurent Pinchart , Sakari Ailus , Mikhail Ulyanov , Fabien Dessenne , Arnd Bergmann , Darren Etheridge , Peter Griffin , Benoit Parrot , Andrew-CT Chen , Eddie Huang , Yingjoe Chen , James Liao , Hongzhou Yang , Daniel Hsiao , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, PoChun.Lin@mediatek.com From: Matthias Brugger Message-ID: <566EA9B1.5000102@gmail.com> Date: Mon, 14 Dec 2015 12:36:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1450081618.5745.3.camel@mtksdaap41> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4774 Lines: 116 On 14/12/15 09:26, tiffany lin wrote: > On Fri, 2015-12-11 at 11:29 -0600, Rob Herring wrote: >> On Fri, Dec 11, 2015 at 05:55:39PM +0800, Tiffany Lin wrote: >>> Add a DT binding documentation of Video Encoder for the >>> MT8173 SoC from Mediatek. >>> >>> Signed-off-by: Tiffany Lin >> >> A question and minor issue below, otherwise: >> >> Acked-by: Rob Herring >> >>> --- >>> .../devicetree/bindings/media/mediatek-vcodec.txt | 58 ++++++++++++++++++++ >>> 1 file changed, 58 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec.txt >>> >>> diff --git a/Documentation/devicetree/bindings/media/mediatek-vcodec.txt b/Documentation/devicetree/bindings/media/mediatek-vcodec.txt >>> new file mode 100644 >>> index 0000000..510cd81 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/media/mediatek-vcodec.txt >>> @@ -0,0 +1,58 @@ >>> +Mediatek Video Codec >>> + >>> +Mediatek Video Codec is the video codec hw present in Mediatek SoCs which >>> +supports high resolution encoding functionalities. >>> + >>> +Required properties: >>> +- compatible : "mediatek,mt8173-vcodec-enc" for encoder >>> +- reg : Physical base address of the video codec registers and length of >>> + memory mapped region. >>> +- interrupts : interrupt number to the cpu. >>> +- mediatek,larb : must contain the local arbiters in the current Socs. This looks strange, shouldn't it be "larb" instead of "mediatek,larb". At least the example does not use the mediatek prefix. >>> +- clocks : list of clock specifiers, corresponding to entries in >>> + the clock-names property; >>> +- clock-names: must contain "vencpll", "venc_lt_sel", "vcodecpll_370p5_ck" >>> +- iommus : list of iommus specifiers should be enabled for hw encode. >>> + There are 2 cells needed to enable/disable iommu. >>> + The first one is local arbiter index(larbid), and the other is port >>> + index(portid) within local arbiter. Specifies the larbid and portid >>> + as defined in dt-binding/memory/mt8173-larb-port.h. >>> +- mediatek,vpu : the node of video processor unit Same here. Regards, Matthias >>> + >>> +Example: >>> +vcodec_enc: vcodec@0x18002000 { >>> + compatible = "mediatek,mt8173-vcodec-enc"; >>> + reg = <0 0x18002000 0 0x1000>, /*VENC_SYS*/ >>> + <0 0x19002000 0 0x1000>; /*VENC_LT_SYS*/ >>> + interrupts = , >>> + ; >>> + larb = <&larb3>, >>> + <&larb5>; >>> + iommus = <&iommu M4U_LARB3_ID M4U_PORT_VENC_RCPU>, >> >> Is this the same iommu as the VPU? If so, you can't have a mixed number >> of cells. > Yes, its same iommus as the VPU. > Now we use two parameters for iommus. > We will fix this in next version. > >>> + <&iommu M4U_LARB3_ID M4U_PORT_VENC_REC>, >>> + <&iommu M4U_LARB3_ID M4U_PORT_VENC_BSDMA>, >>> + <&iommu M4U_LARB3_ID M4U_PORT_VENC_SV_COMV>, >>> + <&iommu M4U_LARB3_ID M4U_PORT_VENC_RD_COMV>, >>> + <&iommu M4U_LARB3_ID M4U_PORT_VENC_CUR_LUMA>, >>> + <&iommu M4U_LARB3_ID M4U_PORT_VENC_CUR_CHROMA>, >>> + <&iommu M4U_LARB3_ID M4U_PORT_VENC_REF_LUMA>, >>> + <&iommu M4U_LARB3_ID M4U_PORT_VENC_REF_CHROMA>, >>> + <&iommu M4U_LARB3_ID M4U_PORT_VENC_NBM_RDMA>, >>> + <&iommu M4U_LARB3_ID M4U_PORT_VENC_NBM_WDMA>, >>> + <&iommu M4U_LARB5_ID M4U_PORT_VENC_RCPU_SET2>, >>> + <&iommu M4U_LARB5_ID M4U_PORT_VENC_REC_FRM_SET2>, >>> + <&iommu M4U_LARB5_ID M4U_PORT_VENC_BSDMA_SET2>, >>> + <&iommu M4U_LARB5_ID M4U_PORT_VENC_SV_COMA_SET2>, >>> + <&iommu M4U_LARB5_ID M4U_PORT_VENC_RD_COMA_SET2>, >>> + <&iommu M4U_LARB5_ID M4U_PORT_VENC_CUR_LUMA_SET2>, >>> + <&iommu M4U_LARB5_ID M4U_PORT_VENC_CUR_CHROMA_SET2>, >>> + <&iommu M4U_LARB5_ID M4U_PORT_VENC_REF_LUMA_SET2>, >>> + <&iommu M4U_LARB5_ID M4U_PORT_VENC_REC_CHROMA_SET2>; >>> + vpu = <&vpu>; >> >> Need to update the example. > Sorry, I didn't get it. > Do you means update VPU binding document "media/mediatek-vpu.txt"? > >> >>> + clocks = <&apmixedsys CLK_APMIXED_VENCPLL>, >>> + <&topckgen CLK_TOP_VENC_LT_SEL>, >>> + <&topckgen CLK_TOP_VCODECPLL_370P5>; >>> + clock-names = "vencpll", >>> + "venc_lt_sel", >>> + "vcodecpll_370p5_ck"; >>> + }; >>> -- >>> 1.7.9.5 >>> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/