Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752665AbbLNPOy (ORCPT ); Mon, 14 Dec 2015 10:14:54 -0500 Received: from mail.kernel.org ([198.145.29.136]:37926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751608AbbLNPOx (ORCPT ); Mon, 14 Dec 2015 10:14:53 -0500 Date: Mon, 14 Dec 2015 12:14:49 -0300 From: Arnaldo Carvalho de Melo To: Matt Fleming Cc: Markus Trippelsdorf , linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH] Fix misleading indentation issues in perf Message-ID: <20151214151449.GH6843@kernel.org> References: <20151212180702.GA753@x4> <20151214104607.GA2571@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151214104607.GA2571@codeblueprint.co.uk> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1584 Lines: 45 Em Mon, Dec 14, 2015 at 10:46:07AM +0000, Matt Fleming escreveu: > On Sat, 12 Dec, at 07:07:02PM, Markus Trippelsdorf wrote: > > perf doesn't build with gcc-6 because of several misleading-indentation > > warnings, e.g.: > > > > arch/x86/tests/intel-cqm.c: In function ‘spawn’: > > arch/x86/tests/intel-cqm.c:21:3: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation] > > sleep(5); > > ^~~~~ > > > > arch/x86/tests/intel-cqm.c:20:2: note: ...this ‘while’ clause, but it is not > > while(1); > > ^~~~~ > > > > Signed-off-by: Markus Trippelsdorf > > > > diff --git a/tools/perf/arch/x86/tests/intel-cqm.c b/tools/perf/arch/x86/tests/intel-cqm.c > > index d28c1b6a3b54..fa5d17af88b7 100644 > > --- a/tools/perf/arch/x86/tests/intel-cqm.c > > +++ b/tools/perf/arch/x86/tests/intel-cqm.c > > @@ -17,7 +17,7 @@ static pid_t spawn(void) > > if (pid) > > return pid; > > > > - while(1); > > + while(1) > > sleep(5); > > return 0; > > } > > Whoops. Good catch. > > Reviewed-by: Matt Fleming So, Markus, can you split this in three patches, stating that in some cases its just cosmetic stuff while in others really a bug got fixed, adding the Reviewed-by: tag for the cqm one? And acked-by for all, from Ingo? - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/