Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752571AbbLNRMb (ORCPT ); Mon, 14 Dec 2015 12:12:31 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:36242 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901AbbLNRM0 (ORCPT ); Mon, 14 Dec 2015 12:12:26 -0500 Date: Tue, 15 Dec 2015 00:14:01 +0800 From: Wang YanQing To: Brian Gerst , mmarek@suse.com Cc: linux-kbuild@vger.kernel.org, Linux Kernel Mailing List , yamada.masahiro@socionext.com Subject: Re: [PATCH] kbuild: support make dir/file.i for *.S Message-ID: <20151214161401.GA8036@udknight> Mail-Followup-To: Wang YanQing , Brian Gerst , mmarek@suse.com, linux-kbuild@vger.kernel.org, Linux Kernel Mailing List , yamada.masahiro@socionext.com References: <20151210163329.GA18947@udknight> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2026 Lines: 53 On Sat, Dec 12, 2015 at 02:13:03PM -0500, Brian Gerst wrote: > On Thu, Dec 10, 2015 at 11:33 AM, Wang YanQing wrote: > > This feature could reduce a little time to expand all > > the macros in *.S for reading. > > > > Signed-off-by: Wang YanQing > > --- > > Makefile | 2 ++ > > scripts/Makefile.build | 6 ++++++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/Makefile b/Makefile > > index 7558c9c..d7e2060 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -1552,6 +1552,8 @@ endif > > $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@) > > %.s: %.S prepare scripts FORCE > > $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@) > > +%.i: %.S prepare scripts FORCE > > + $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@) > > %.o: %.S prepare scripts FORCE > > $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@) > > %.symtypes: %.c prepare scripts FORCE > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > > index 2c47f9c..2a51d49 100644 > > --- a/scripts/Makefile.build > > +++ b/scripts/Makefile.build > > @@ -287,6 +287,12 @@ cmd_as_s_S = $(CPP) $(a_flags) -o $@ $< > > $(obj)/%.s: $(src)/%.S FORCE > > $(call if_changed_dep,as_s_S) > > > > +quiet_cmd_cc_i_S = CPP $(quiet_modtag) $@ > > +cmd_cc_i_S = $(CPP) $(a_flags) -o $@ $< > > + > > +$(obj)/%.i: $(src)/%.S FORCE > > + $(call if_changed_dep,cc_i_S) > > + > > quiet_cmd_as_o_S = AS $(quiet_modtag) $@ > > cmd_as_o_S = $(CC) $(a_flags) -c -o $@ $< > > *.s (lower case) is the suffix used for preprocessed assembly files, > and there is already a rule for that. *.i is for preprocessed C > files. Agreed, you are right! Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/