Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752822AbbLNQjr (ORCPT ); Mon, 14 Dec 2015 11:39:47 -0500 Received: from mail-qk0-f171.google.com ([209.85.220.171]:36815 "EHLO mail-qk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751448AbbLNQjp (ORCPT ); Mon, 14 Dec 2015 11:39:45 -0500 MIME-Version: 1.0 In-Reply-To: <1450099368.3358.5.camel@hadess.net> References: <1450097429-4959-1-git-send-email-akihiko.odaki.4i@stu.hosei.ac.jp> <1450099368.3358.5.camel@hadess.net> Date: Mon, 14 Dec 2015 11:39:43 -0500 Message-ID: Subject: Re: [PATCH 1/2] HID: Use multitouch driver for Type Covers From: Donavan Lance To: Bastien Nocera Cc: Akihiko Odaki , jikos@kernel.org, Benjamin Tissoires , linux-input , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1532 Lines: 33 On Mon, Dec 14, 2015 at 8:22 AM, Bastien Nocera wrote: > On Mon, 2015-12-14 at 21:50 +0900, Akihiko Odaki wrote: >> Use multitouch driver instead of microsoft one for Microsoft Surface >> Type Covers. >> >> By using MT_CLS_EXPORT_ALL_INPUTS, the keyboards function as well as >> the multitouch pads do. > > I've discussed this a couple of weeks back with Benjamin Tissoires, and > this patch would break the special keys (mute, brightness up/down, > keyboard backlight up/down and play/pause). > > The recommended way to fix this was to move multi-touch processing into > the Microsoft driver, so that it would handle the trackpad's multi- > touch events. > > You should be able to do this by carefully picking up the handling code > from hid-multitouch, or do something similar to what's done in hid- > wacom, which has the same problem as the Type Cover handling. > > Can you confirm that this does indeed break those special keys? If it > does, it's a NAK from my side. For what it's worth the special keys on my keyboard work fine when using this patch. I'm using a Surface Pro 3, Type Cover 3, running GNOME and Fedora 23. The search, share, connect(?), and settings keys are the only ones not mapped to anything out of the box, but they are recognized by xev. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/