Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753339AbbLNR6r (ORCPT ); Mon, 14 Dec 2015 12:58:47 -0500 Received: from mail-ig0-f178.google.com ([209.85.213.178]:36990 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752830AbbLNR6q (ORCPT ); Mon, 14 Dec 2015 12:58:46 -0500 MIME-Version: 1.0 In-Reply-To: <20151212101142.GA3867@pd.tnic> References: <456153d09e85f2f139020a051caed3ca8f8fca73.1449861203.git.tony.luck@intel.com> <20151212101142.GA3867@pd.tnic> Date: Mon, 14 Dec 2015 10:58:45 -0700 Message-ID: Subject: Re: [PATCHV2 1/3] x86, ras: Add new infrastructure for machine check fixup tables From: Ross Zwisler To: Borislav Petkov Cc: Tony Luck , linux-nvdimm , X86 ML , linux-kernel@vger.kernel.org, Ingo Molnar , linux-mm@kvack.org, Andy Lutomirski , Andrew Morton , Ross Zwisler Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1469 Lines: 36 On Sat, Dec 12, 2015 at 3:11 AM, Borislav Petkov wrote: > On Thu, Dec 10, 2015 at 01:58:04PM -0800, Tony Luck wrote: <> >> +#ifdef CONFIG_MCE_KERNEL_RECOVERY >> +/* Given an address, look for it in the machine check exception tables. */ >> +const struct exception_table_entry *search_mcexception_tables( >> + unsigned long addr) >> +{ >> + const struct exception_table_entry *e; >> + >> + e = search_extable(__start___mcex_table, __stop___mcex_table-1, addr); >> + return e; >> +} >> +#endif > > You can make this one a bit more readable by doing: > > /* Given an address, look for it in the machine check exception tables. */ > const struct exception_table_entry * > search_mcexception_tables(unsigned long addr) > { > #ifdef CONFIG_MCE_KERNEL_RECOVERY > return search_extable(__start___mcex_table, > __stop___mcex_table - 1, addr); > #endif > } With this code if CONFIG_MCE_KERNEL_RECOVERY isn't defined you'll get a compiler error that the function doesn't have a return statement, right? I think we need an #else to return NULL, or to have the #ifdef encompass the whole function definition as it was in Tony's version. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/