Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753333AbbLNSKb (ORCPT ); Mon, 14 Dec 2015 13:10:31 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:48440 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752928AbbLNSKa (ORCPT ); Mon, 14 Dec 2015 13:10:30 -0500 Date: Mon, 14 Dec 2015 21:09:54 +0300 From: Dan Carpenter To: Nicholas Mc Guire Cc: "Marciniszyn, Mike" , "devel@driverdev.osuosl.org" , "linux-rdma@vger.kernel.org" , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Doug Ledford , Nicholas Mc Guire , "Hefty, Sean" , Hal Rosenstock Subject: Re: [PATCH 1/3] staging/rdma/hfi1: consolidate kmalloc_array+memset into kcalloc Message-ID: <20151214180954.GZ5284@mwanda> References: <1450104189-2653-1-git-send-email-hofrat@osadl.org> <32E1700B9017364D9B60AED9960492BC259CD82D@fmsmsx120.amr.corp.intel.com> <20151214174123.GB22987@osadl.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151214174123.GB22987@osadl.at> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 640 Lines: 16 On Mon, Dec 14, 2015 at 05:41:23PM +0000, Nicholas Mc Guire wrote: > I obviously made a real mess here. > I incorrectly concluded that rxcontext is 0 which it is not in some cases Yep. Plus you build tested it but assumed that the unused variable warning must have been there in the original... I've done that for static checker warnings. Lesson learned, hopefully. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/