Date: Mon, 14 Dec 2015 14:11:46 -0500
From: "Raj, Ashok" <ashok.raj@intel.com>
To: Borislav Petkov <bp@suse.de>
Cc: Eduardo Habkost <ehabkost@redhat.com>, kvm@vger.kernel.org,
        Tony Luck <tony.luck@intel.com>, Gong Chen <gong.chen@intel.com>,
        Gleb Natapov <gleb@kernel.org>, linux-kernel@vger.kernel.org,
        qemu-devel@nongnu.org, Andi Kleen <andi.kleen@intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE
 support to QEMU
Message-ID: <20151214191145.GB18012@otc-brkl-03.jf.intel.com>
References: <1449776482-26070-1-git-send-email-ashok.raj@intel.com>
 <20151214162356.GA5314@thinpad.lan.raisama.net>
 <20151214163738.GJ11630@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151214163738.GJ11630@pd.tnic>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 935
Lines: 26

On Mon, Dec 14, 2015 at 05:37:38PM +0100, Borislav Petkov wrote:
> 
> ... and obviously LMCE is vendor-specific so it cannot be enabled on
> !Intel guests with a define like that. mce_init() in qemu should check
> vendor too.
> 
> The same mistake was done with SER_P but that's much harder to change,
> as we discussed previously.
> 

This is mostly harmless.. since the MCG_CAP space is shared and has no
conflict between vendors. Also just the CAP being set has no effect.

The Guest OS needs to opt-in and the SIGBUS indicating SRAR are the only 
ones that are treated special treatment. Also Intel was the only one
broadcasting MCE's.. so we are like the rest now :-)

Cheers,
Ashok


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/