Message-ID: <87fuz4r2d8.wl%kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Eduardo Valentin <edubezval@gmail.com>
CC: Simon <horms@verge.net.au>, Zhang Rui <rui.zhang@intel.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Magnus <magnus.damm@gmail.com>, <linux-sh@vger.kernel.org>,
        <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 8/8 v4] thermal: of-thermal: of_thermal_set_trip_temp() call thermal_zone_device_update()
In-Reply-To: <20151214211103.GB10924@localhost.localdomain>
References: <87vb895x9d.wl%kuninori.morimoto.gx@renesas.com>
	<87io495x3c.wl%kuninori.morimoto.gx@renesas.com>
	<20151214211103.GB10924@localhost.localdomain>
User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="US-ASCII"
Date: Tue, 15 Dec 2015 00:20:59 +0000
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2015 00:20:59.1437 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR06MB1012
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1352
Lines: 38


Hi Eduardo

> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > 
> > of_thermal_set_trip_temp() updates trip temperature. It should call
> > thermal_zone_device_update() immediately.
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > v3 -> v4
> > 
> >  - no change
> > 
> >  drivers/thermal/of-thermal.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
> > index 42b7d42..a1dd7b1 100644
> > --- a/drivers/thermal/of-thermal.c
> > +++ b/drivers/thermal/of-thermal.c
> > @@ -334,6 +334,8 @@ static int of_thermal_set_trip_temp(struct thermal_zone_device *tz, int trip,
> >  	/* thermal framework should take care of data->mask & (1 << trip) */
> >  	data->trips[trip].temperature = temp;
> >  
> > +	thermal_zone_device_update(tz);
> > +
> 
> Although I understand the need for this, I would prefer you move this change
> to thermal_core.c. The reasoning is to keep the same behavior for
> thermal zones created over of thermal and regular thermal zones.

Indeed. will do in v5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/