Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932955AbbLOAXA (ORCPT ); Mon, 14 Dec 2015 19:23:00 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:39016 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932664AbbLOAW7 (ORCPT ); Mon, 14 Dec 2015 19:22:59 -0500 X-AuditID: cbfec7f4-f79026d00000418a-6c-566f5d60aa11 Subject: Re: [PATCH] extcon: max77693: fix handling return value of regmap_irq_get_virq To: Andrzej Hajda , Chanwoo Choi References: <1450091562-31811-1-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , MyungJoo Ham , linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <566F5D5E.7070007@samsung.com> Date: Tue, 15 Dec 2015 09:22:54 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <1450091562-31811-1-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNLMWRmVeSWpSXmKPExsVy+t/xK7oJsflhBr1ntC1urTvHarFxxnpW i+tfnrNavH5haHF51xw2i7VH7rJb3G5cwebA7tG3ZRWjx+dNcgFMUVw2Kak5mWWpRfp2CVwZ c3u+MRacZa5Yu/AWYwNjA3MXIyeHhICJxMuDn9kgbDGJC/fWA9lcHEICSxklWrfcYoZwnjJK XLo9mxGkSlggUmLm0Z0sILaIgK/E6advGCGKeoA6nkN0MAtsYJTYcuAs2A42AWOJzcuXgO3g FdCSmL15B5jNIqAqsfvdN6YuRg4OUYEIiUU7MiFKBCV+TL4HtoBTwEVi3q87rCAlzAJ6Evcv aoGEmQXkJTavecs8gVFgFpKOWQhVs5BULWBkXsUomlqaXFCclJ5rqFecmFtcmpeul5yfu4kR EsRfdjAuPmZ1iFGAg1GJh/cHa36YEGtiWXFl7iFGCQ5mJRHeYgugEG9KYmVValF+fFFpTmrx IUZpDhYlcd65u96HCAmkJ5akZqemFqQWwWSZODilGhgrThrvdZSreTatJ+UgC3dJ6sIzktqG q7Z/tpGoe2tzL3Hr4SoLxgyuqdwc979E33/VmP4iKveGhMqJpUWzzU+s2b2xf/IFu0uPc8o6 DkyYtE1439Hb5aatAtwlcfki/y8VnDx4PCdcwrlQ/J9b3sncxAkT5VtS5W/Za7RlPT9asnS9 q89lMRclluKMREMt5qLiRAA7wimLXgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 691 Lines: 20 On 14.12.2015 20:12, Andrzej Hajda wrote: > The function can return negative values, so its result should > be assigned to signed variable. > > Signed-off-by: Andrzej Hajda > Suggested-by: Krzysztof Kozlowski > --- > drivers/extcon/extcon-max77693.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/