From: Dexuan Cui <decui@microsoft.com>
To: David Miller <davem@davemloft.net>, "tj@kernel.org" <tj@kernel.org>
CC: "pablo@netfilter.org" <pablo@netfilter.org>,
        "kaber@trash.net" <kaber@trash.net>,
        "kadlec@blackhole.kfki.hu" <kadlec@blackhole.kfki.hu>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>,
        "daniel.wagner@bmw-carit.de" <daniel.wagner@bmw-carit.de>,
        "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>,
        "lizefan@huawei.com" <lizefan@huawei.com>,
        "hannes@cmpxchg.org" <hannes@cmpxchg.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "netfilter-devel@vger.kernel.org" <netfilter-devel@vger.kernel.org>,
        "coreteam@netfilter.org" <coreteam@netfilter.org>,
        "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-team@fb.com" <kernel-team@fb.com>,
        "ninasc@fb.com" <ninasc@fb.com>
Subject: RE: [PATCH net-next] net, cgroup: cgroup_sk_updat_lock was missing
 initializer
Thread-Topic: [PATCH net-next] net, cgroup: cgroup_sk_updat_lock was missing
 initializer
Thread-Index: AQHRNt3j03AJDe7eYUmIMeWATmRYUw==
Date: Tue, 15 Dec 2015 02:11:20 +0000
Message-ID: <9f79b2053ba7422b816cfc34d380e5d6@HKXPR3004MB0088.064d.mgd.msft.net>
References: <1449527935-27056-1-git-send-email-tj@kernel.org>
	<f90d369a0e004fee8d3bfdfe95e0abc0@HKXPR3004MB0088.064d.mgd.msft.net>
	<20151214162406.GA4026@mtj.duckdns.org>
 <20151214.142043.1185024338854399910.davem@davemloft.net>
In-Reply-To: <20151214.142043.1185024338854399910.davem@davemloft.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2015 02:11:26.7234
 (UTC)
X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=72f988bf-86f1-41af-91ab-2d7cd011db47;Ip=[23.103.249.84];Helo=[064-smtp-out.microsoft.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB0729
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1425
Lines: 36

> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Tuesday, December 15, 2015 3:21
> To: tj@kernel.org
> Cc: Dexuan Cui <decui@microsoft.com>; pablo@netfilter.org; kaber@trash.net;
> kadlec@blackhole.kfki.hu; daniel@iogearbox.net; daniel.wagner@bmw-carit.de;
> nhorman@tuxdriver.com; lizefan@huawei.com; hannes@cmpxchg.org;
> netdev@vger.kernel.org; netfilter-devel@vger.kernel.org;
> coreteam@netfilter.org; cgroups@vger.kernel.org; linux-
> kernel@vger.kernel.org; kernel-team@fb.com; ninasc@fb.com
> Subject: Re: [PATCH net-next] net, cgroup: cgroup_sk_updat_lock was missing
> initializer
> 
> From: Tejun Heo <tj@kernel.org>
> Date: Mon, 14 Dec 2015 11:24:06 -0500
> 
> > bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup") added global
> > spinlock cgroup_sk_update_lock but erroneously skipped initializer
> > leading to uninitialized spinlock warning.  Fix it by using
> > DEFINE_SPINLOCK().
> >
> > Signed-off-by: Tejun Heo <tj@kernel.org>
> > Reported-by: Dexuan Cui <decui@microsoft.com>
> > Fixes: bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup")
> 
> Applied, thanks.

Thanks! I can confirm it fixed the issue.

Thanks,
-- Dexuan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/