Subject: Re: [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes
 improvement
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <5655990D.7090300@linux.vnet.ibm.com>
 <20151214185513.GA19131@kroah.com>
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
        dvyukov@google.com, yanmin_zhang@linux.intel.com
From: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
Message-ID: <566FA86B.6060408@linux.vnet.ibm.com>
Date: Tue, 15 Dec 2015 13:43:07 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151214185513.GA19131@kroah.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1100
Lines: 26

Hi, Greg
	This patch is dropped, I have created another patch based on Jiri' patch.
On 2015/12/15 02:55, Greg Kroah-Hartman wrote:
> On Wed, Nov 25, 2015 at 07:18:37PM +0800, xinhui wrote:
>> From: xinhui <xinhui@linux.vnet.ibm.com>
>>
>> If gsm driver fails to activate one mux, and this mux is not stored in
>> gsm_mux[], there would be a warning in gsm_cleanup_mux(). Actually this
>> is a legal case. So just do a simple check instead of WARN_ON.
>>
>> There is one filed gsm->num to store its index of gsm_mux[]. So use
>> gsm->num to remove itself from gsm_mux[] instead of the for-loop
>> traverse.
>>
>> Reported-by: Dmitry Vyukov <dvyukov@google.com>
>> Fixes: 5a64096700dc ("tty/n_gsm.c: fix a memory leak in gsmld_open")
>> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
>
> the signed-off-by name has to match your from: name :(
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/