MIME-Version: 1.0
In-Reply-To: <20151214205830.135c7ca3@gmail.com>
References: <20151211130233.GJ5284@mwanda>
	<20151211212416.6238df0d@gmail.com>
	<20151212085744.GO5284@mwanda>
	<20151212025850.47738101@gmail.com>
	<20151214191451.GA30170@kroah.com>
	<20151214190331.6600da75@gmail.com>
	<20151215043439.GB28216@kroah.com>
	<20151214194525.1fd26717@gmail.com>
	<20151215052153.GA30050@kroah.com>
	<20151214202247.05593fb9@gmail.com>
	<20151215054604.GA27573@kroah.com>
	<20151214205830.135c7ca3@gmail.com>
Date: Tue, 15 Dec 2015 12:07:07 +0530
Message-ID: <CA+5yK5Go4xYnFCqpWQKyajbaGgJBzHoHNgmz9hT55wFCUCBhRQ@mail.gmail.com>
Subject: Re: [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes
From: Amitoj Kaur Chawla <amitoj1606@gmail.com>
To: Sanidhya Solanki <jpage.lkml@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, devel@driverdev.osuosl.org,
        driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
        Dan Carpenter <dan.carpenter@oracle.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1519
Lines: 40

On Tue, Dec 15, 2015 at 7:28 AM, Sanidhya Solanki <jpage.lkml@gmail.com> wrote:
>
> Patch contains the spacing fixes that led to checkpatch.pl warnings.
>
> Signed-off-by: Sanidhya Solanki <jpage.lkml@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_cls.c    |   4 +-
>  drivers/staging/dgnc/dgnc_driver.h |   8 --
>  drivers/staging/dgnc/dgnc_neo.c    | 235
> ++++++++++++++++++++++++-------------
> drivers/staging/dgnc/dgnc_neo.h    |  22 ++--
> drivers/staging/dgnc/dgnc_pci.h    |   1 -
> drivers/staging/dgnc/dgnc_sysfs.c  |  18 ++-
> drivers/staging/dgnc/dgnc_tty.c    |  46 +++++---
> drivers/staging/dgnc/digi.h        |  32 ++--- 8 files changed, 223
> insertions(+), 143 deletions(-)
>

Hi Sanidhya,

Just to help you out since you're struggling some.

Subject line should be something like "Fix checkpatch warnings".
Better yet would be a subject specifying what you fixed to silence
checkpatch warnings. For example, "Fixed comments formatting" or
"Removed unnecessary spaces"

And the commit message should not be vague like "Patch contains the
spacing fixes that led to checkpatch.pl warnings." You should write
what you did to fix the warnings.
For example: Fixed checkpatch warning *write warning here* by
correcting *whatever change you did*

Regards,
Amitoj
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/