Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753625AbbLOIBM (ORCPT ); Tue, 15 Dec 2015 03:01:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56610 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753111AbbLOIBK (ORCPT ); Tue, 15 Dec 2015 03:01:10 -0500 Date: Tue, 15 Dec 2015 09:01:06 +0100 From: Jiri Olsa To: Wang Nan Cc: acme@kernel.org, namhyung@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com, a.p.zijlstra@chello.nl, masami.hiramatsu.pt@hitachi.com, linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo Subject: Re: [PATCH] perf tests: Fix false TEST_OK result for 'perf test hist' Message-ID: <20151215080106.GA16565@krava.brq.redhat.com> References: <1450153124-130381-1-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450153124-130381-1-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1633 Lines: 43 On Tue, Dec 15, 2015 at 04:18:44AM +0000, Wang Nan wrote: > Commit 71d6de64feddd4b455555326fba2111b3006d9e0 ('perf test: Fix hist > testcases when kptr_restrict is on') solves a double free problem when > 'perf test hist' calling setup_fake_machine(). However, the result is > still incorrect. For example: > > $ ./perf test -v 'filtering hist entries' > 25: Test filtering hist entries : > --- start --- > test child forked, pid 4186 > Cannot create kernel maps > test child finished with 0 > ---- end ---- > Test filtering hist entries: Ok > > In this case the body of this test is not get executed at all, but the > result is 'Ok'. I think 'Skip' should be better. > > The reason is that *ALL* hists test cases forget to reset err after > using it to hold an error code. > > This patch ensure err is reset. > > In case when kptr_restrict prevent normal user get kernel address, this > test should be skipped, not fail. This patch uses linux/err.h to store > error code in return value of setup_fake_machine(), and let 'EACCES' to > indicate this problem. > > Signed-off-by: Wang Nan > Cc: Arnaldo Carvalho de Melo > Cc: Jiri Olsa > Cc: Masami Hiramatsu > Cc: Namhyung Kim Acked-by: Jiri Olsa thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/