Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964814AbbLOJEP (ORCPT ); Tue, 15 Dec 2015 04:04:15 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33733 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933212AbbLOJED (ORCPT ); Tue, 15 Dec 2015 04:04:03 -0500 Date: Tue, 15 Dec 2015 18:03:21 +0900 From: Namhyung Kim To: Wang Nan Cc: acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com, a.p.zijlstra@chello.nl, masami.hiramatsu.pt@hitachi.com, linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo Subject: Re: [PATCH v2] perf test: Fix false TEST_OK result for 'perf test hist' Message-ID: <20151215090321.GB1821@danjae.kornet> References: <20151215075242.GA1821@danjae.kornet> <1450166966-135536-1-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1450166966-135536-1-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2405 Lines: 76 On Tue, Dec 15, 2015 at 08:09:26AM +0000, Wang Nan wrote: > Commit 71d6de64feddd4b455555326fba2111b3006d9e0 ('perf test: Fix hist > testcases when kptr_restrict is on') solves a double free problem when > 'perf test hist' calling setup_fake_machine(). However, the result is > still incorrect. For example: > > $ ./perf test -v 'filtering hist entries' > 25: Test filtering hist entries : > --- start --- > test child forked, pid 4186 > Cannot create kernel maps > test child finished with 0 > ---- end ---- > Test filtering hist entries: Ok > > In this case the body of this test is not get executed at all, but the > result is 'Ok'. > > Actually, in setup_fake_machine() there's no need to create real kernel > maps. What we want is the fake maps. This patch removes the > machine__create_kernel_maps() in setup_fake_machine(), so it won't be > affected by kptr_restrict setting. > > Test result: > > $ cat /proc/sys/kernel/kptr_restrict > 1 > $ ~/perf test -v hist > 15: Test matching and linking multiple hists : > --- start --- > test child forked, pid 24031 > test child finished with 0 > ---- end ---- > Test matching and linking multiple hists: Ok > [SNIP] > > Signed-off-by: Wang Nan > Suggested-by: Namhyung Kim > Cc: Arnaldo Carvalho de Melo > Cc: Jiri Olsa > Cc: Masami Hiramatsu Acked-by: Namhyung Kim Thanks, Namhyung > --- > tools/perf/tests/hists_common.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/tools/perf/tests/hists_common.c b/tools/perf/tests/hists_common.c > index bcfd081..071a8b5 100644 > --- a/tools/perf/tests/hists_common.c > +++ b/tools/perf/tests/hists_common.c > @@ -87,11 +87,6 @@ struct machine *setup_fake_machine(struct machines *machines) > return NULL; > } > > - if (machine__create_kernel_maps(machine)) { > - pr_debug("Cannot create kernel maps\n"); > - return NULL; > - } > - > for (i = 0; i < ARRAY_SIZE(fake_threads); i++) { > struct thread *thread; > > -- > 1.8.3.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/