Message-ID: <566FE62B.6060500@linaro.org>
Date: Tue, 15 Dec 2015 10:06:35 +0000
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Andrew Lunn <andrew@lunn.ch>, GregKH <greg@kroah.com>,
        maxime.ripard@free-electrons.com, wsa@the-dreams.de,
        broonie@kernel.org, vz@mleia.com
CC: afd@ti.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] Convert existing EEPROM drivers to NVMEM
References: <1449583511-22521-1-git-send-email-andrew@lunn.ch>
In-Reply-To: <1449583511-22521-1-git-send-email-andrew@lunn.ch>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2250
Lines: 51


Thanks Andrew for looking into this.

On 08/12/15 14:05, Andrew Lunn wrote:
> This patches converts the old EEPROM drivers in driver/misc/eeprom to
> use the NVMEM framework. These drivers export there content in /sys as
> read only to root, since the EEPROM may contain sensitive information.
> So the first patch adds a flag so the NVMEM framework will create its
> file in /sys as root read only.
>
> To keep backwards compatibility with these older drivers, the contents
> of the EEPROM must be exports in sysfs in a file called eeprom in the
> devices node in sys, where as the NVMEM places them under class/nvmem.
> So add this optional backwards compatible to the framework.
>
> Then convert the at24, at25 and 93xx46 by adding regmap support,
> removing each drivers own /sys code and registering with the NVMEM
> framework.
>
> AT24 and 93xx46 has been boot tested, at25 compile tested only.
>
> Andrew Lunn (6):
>    nvmem: Add flag to export NVMEM to root only
>    nvmem: Add backwards compatibility support for older EEPROM drivers.
>    eeprom: at24: extend driver to plug into the NVMEM framework
>    eeprom: at25: Remove in kernel API for accessing the EEPROM
>    eeprom: at25: extend driver to plug into the NVMEM framework
>    eeprom: 93xx46: extend driver to plug into the NVMEM framework
>
>   drivers/misc/eeprom/Kconfig         |   9 +++
>   drivers/misc/eeprom/at24.c          | 119 +++++++++++++++++++----------
>   drivers/misc/eeprom/at25.c          | 147 ++++++++++++++++--------------------
>   drivers/misc/eeprom/eeprom_93xx46.c | 121 ++++++++++++++++++++++-------
>   drivers/nvmem/Kconfig               |   7 ++
>   drivers/nvmem/core.c                | 132 ++++++++++++++++++++++++++++++--
>   include/linux/nvmem-provider.h      |  11 +++
>   include/linux/spi/eeprom.h          |   2 -
>   8 files changed, 393 insertions(+), 155 deletions(-)


I did test this patchset on my board with at24, series looks good.
Other than some comments on few  patches.


--srini
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/