Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964939AbbLOK1O (ORCPT ); Tue, 15 Dec 2015 05:27:14 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:35926 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964848AbbLOK1K (ORCPT ); Tue, 15 Dec 2015 05:27:10 -0500 Message-ID: <566FEAE7.10109@linaro.org> Date: Tue, 15 Dec 2015 10:26:47 +0000 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Andrew Lunn CC: GregKH , maxime.ripard@free-electrons.com, wsa@the-dreams.de, broonie@kernel.org, vz@mleia.com, afd@ti.com, linux-kernel@vger.kernel.org, agust@denx.de Subject: Re: [PATCH 6/6] eeprom: 93xx46: extend driver to plug into the NVMEM framework References: <1449583511-22521-1-git-send-email-andrew@lunn.ch> <1449583511-22521-7-git-send-email-andrew@lunn.ch> <566FE5D4.1060601@linaro.org> <20151215101715.GC17792@lunn.ch> In-Reply-To: <20151215101715.GC17792@lunn.ch> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1045 Lines: 29 + adding Anatolij On 15/12/15 10:17, Andrew Lunn wrote: >> Is there a reason for this driver to be using the old style? >> I can understand the issues with at24/at25 but does this driver also >> suffer from such issues? > > In order to keep backwards compatibility, we need the older file in > /sys. The only other option is to remove it and see if anybody > complains about us breaking the ABI. We should atleast attempt to pitch in this direction, and ask if somebody really cares if the location of the eeprom/nvmem file matters to them? We should probably check with Anatolij Gustschin. Anatolij, Do you see any issues if we totally move this driver to nvmem framework? Which involves relocating and renameing the old eeprom file to /sys/bus/nvmem/devices/*/nvmem --srini > > Andrew > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/