Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753790AbbLOKv2 (ORCPT ); Tue, 15 Dec 2015 05:51:28 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:36008 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752504AbbLOKv1 (ORCPT ); Tue, 15 Dec 2015 05:51:27 -0500 Message-ID: <566FF0AC.7090200@linaro.org> Date: Tue, 15 Dec 2015 10:51:24 +0000 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Andrew Lunn CC: GregKH , maxime.ripard@free-electrons.com, wsa@the-dreams.de, broonie@kernel.org, vz@mleia.com, afd@ti.com, linux-kernel@vger.kernel.org, agust@denx.de Subject: Re: [PATCH 6/6] eeprom: 93xx46: extend driver to plug into the NVMEM framework References: <1449583511-22521-1-git-send-email-andrew@lunn.ch> <1449583511-22521-7-git-send-email-andrew@lunn.ch> <566FE5D4.1060601@linaro.org> <20151215101715.GC17792@lunn.ch> <566FEAE7.10109@linaro.org> <20151215103727.GD17792@lunn.ch> In-Reply-To: <20151215103727.GD17792@lunn.ch> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1272 Lines: 37 On 15/12/15 10:37, Andrew Lunn wrote: > On Tue, Dec 15, 2015 at 10:26:47AM +0000, Srinivas Kandagatla wrote: >> + adding Anatolij >> >> On 15/12/15 10:17, Andrew Lunn wrote: >>>> Is there a reason for this driver to be using the old style? >>>> I can understand the issues with at24/at25 but does this driver also >>>> suffer from such issues? >>> >>> In order to keep backwards compatibility, we need the older file in >>> /sys. The only other option is to remove it and see if anybody >>> complains about us breaking the ABI. >> We should atleast attempt to pitch in this direction, and ask if >> somebody really cares if the location of the eeprom/nvmem file >> matters to them? > > I expect it does matter. > > This driver does not implement the in kernel API for accessing the > EEPROM. That means all users are in user space. And if this file > moves, it seems very likely these user space users break. We have no choice I guess, other than adding the NEMEM_COMPAT flag to this driver too :-) > > Andrew > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/