Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753877AbbLOMVG (ORCPT ); Tue, 15 Dec 2015 07:21:06 -0500 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:52293 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932225AbbLOMVD (ORCPT ); Tue, 15 Dec 2015 07:21:03 -0500 Date: Tue, 15 Dec 2015 12:20:38 +0000 From: Russell King - ARM Linux To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Nicolas Pitre , Tony Lindgren , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, "devicetree@vger.kernel.org" , Ivaylo Dimitrov , Laura Abbott , Sebastian Reichel , Will Deacon , linux-kernel@vger.kernel.org, Rob Herring , Pavel Machek , Grant Likely , linux-omap@vger.kernel.org, Frank Rowand , Andreas =?iso-8859-1?Q?F=E4rber?= Subject: Re: [PATCH 5/5] arm: boot: store ATAGs structure into DT "/chosen/linux,atags" entry Message-ID: <20151215122038.GI30871@n2100.arm.linux.org.uk> References: <20150713131902.GH26485@atomide.com> <20151129180939.GE30871@n2100.arm.linux.org.uk> <201511300115.12478@pali> <20151130152352.GY2517@atomide.com> <20151130153933.GD29576@pali> <20151215093325.GK13531@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151215093325.GK13531@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1242 Lines: 29 On Tue, Dec 15, 2015 at 10:33:25AM +0100, Pali Roh?r wrote: > So am I understand correctly that solution would be to hack > arch/arm/mm/mmu.c to not overwrite page at PHYS_OFFSET? That's completely unnecessary: there are enough platform hooks to cope with whatever the platform requires. If you want to reserve the memory, then you have the ->reserve callback, where you can call: memblock_reserve(PHYS_OFFSET, PAGE_SIZE); if you wish to prevent the first page being overwritten. You're then responsible for freeing this page later in the boot sequence, or you could just keep it around and refer to the atags in that page directly. You could also just save_atags() in there, with a comment saying that this is a work-around for N900 which needs the ATAGs saved, and this is allowed in ->reserve as a special exception. -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/