Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933467AbbLONM2 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Dec 2015 08:12:28 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54733 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932176AbbLONM1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Dec 2015 08:12:27 -0500
Date: Tue, 15 Dec 2015 14:12:23 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, masami.hiramatsu.pt@hitachi.com, jolsa@kernel.org,
        linux-kernel@vger.kernel.org, pi3orama@163.com, lizefan@huawei.com,
        He Kuang <hekuang@huawei.com>, Alexei Starovoitov <ast@kernel.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v5 05/14] perf tools: Enable BPF object configure syntax
Message-ID: <20151215131223.GA31734@krava.brq.redhat.com>
References: <1450089563-122430-1-git-send-email-wangnan0@huawei.com>
 <1450089563-122430-6-git-send-email-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1450089563-122430-6-git-send-email-wangnan0@huawei.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2455
Lines: 64

On Mon, Dec 14, 2015 at 10:39:14AM +0000, Wang Nan wrote:

SNIP

>     -e, --event <event>   event selector. use 'perf list' to list available events
> 
>  # ./perf record -e './test_bpf_map_1.c/xmaps:channel.value=10/' usleep 10
>  event syntax error: '..pf_map_1.c/xmaps:channel.value=10/'
>                                    \___ Invalid object config option
>  [SNIP]
> 
>  # ./perf record -e './test_bpf_map_1.c/maps:xchannel.value=10/' usleep 10
>  event syntax error: '..p_1.c/maps:xchannel.value=10/'
>                                    \___ Target map not exist
>  [SNIP]
> 
>  # ./perf record -e './test_bpf_map_1.c/maps:channel.xvalue=10/' usleep 10
>  event syntax error: '..ps:channel.xvalue=10/'
>                                    \___ Invalid object maps config option
>  [SNIP]
> 
>  # ./perf record -e './test_bpf_map_1.c/maps:channel.value=x10/' usleep 10
>  event syntax error: '..nnel.value=x10/'
>                                    \___ Incorrect value type for map
>  [SNIP]
> 
>  Change BPF_MAP_TYPE_ARRAY to '1':
> 
>  # ./perf record -e './test_bpf_map_1.c/maps:channel.value=10/' usleep 10
>  event syntax error: '..ps:channel.value=10/'
>                                    \___ Can't use this config term to this type of map
> 
>  Hint:	Valid config term:
>      	maps:[<arraymap>].value=[value]
>      	(add -v to see detail)
> 
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> Signed-off-by: He Kuang <hekuang@huawei.com>
> Cc: Alexei Starovoitov <ast@kernel.org>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Zefan Li <lizefan@huawei.com>
> Cc: pi3orama@163.com
> ---
>  tools/perf/util/parse-events.c | 56 +++++++++++++++++++++++++++++++++++++++---
>  tools/perf/util/parse-events.h |  3 ++-
>  tools/perf/util/parse-events.l |  2 +-
>  tools/perf/util/parse-events.y | 23 ++++++++++++++---
>  4 files changed, 75 insertions(+), 9 deletions(-)

I don't understand the bpf stuff, but as far as config terms this
change look ok to me, so for bison/flex parser related changes:

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/