Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965169AbbLOOyg (ORCPT ); Tue, 15 Dec 2015 09:54:36 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:32803 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932734AbbLOOye (ORCPT ); Tue, 15 Dec 2015 09:54:34 -0500 Date: Tue, 15 Dec 2015 16:54:27 +0200 From: Aya Mahfouz To: Peter Korsgaard , Greg Kroah-Hartman , Jiri Slaby , Julia Lawall , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tty: serial: constify uartlite_reg_ops structs Message-ID: <20151215145427.GD6125@waves> References: <20151214234205.GA5972@waves> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151214234205.GA5972@waves> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2220 Lines: 70 On Tue, Dec 15, 2015 at 01:42:05AM +0200, Aya Mahfouz wrote: > Constifies uartlite_reg_ops structures in tty's > serial port driver since they are not modified > after their initialization. > > Detected and found using Coccinelle. > > Suggested-by: Julia Lawall > Signed-off-by: Aya Mahfouz > --- > drivers/tty/serial/uartlite.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c > index b1c6bd3..733cf58 100644 > --- a/drivers/tty/serial/uartlite.c > +++ b/drivers/tty/serial/uartlite.c > @@ -72,7 +72,7 @@ static void uartlite_outbe32(u32 val, void __iomem *addr) > iowrite32be(val, addr); > } > > -static struct uartlite_reg_ops uartlite_be = { > +static const struct uartlite_reg_ops uartlite_be = { > .in = uartlite_inbe32, > .out = uartlite_outbe32, > }; > @@ -87,21 +87,21 @@ static void uartlite_outle32(u32 val, void __iomem *addr) > iowrite32(val, addr); > } > > -static struct uartlite_reg_ops uartlite_le = { > +static const struct uartlite_reg_ops uartlite_le = { > .in = uartlite_inle32, > .out = uartlite_outle32, > }; > > static inline u32 uart_in32(u32 offset, struct uart_port *port) > { > - struct uartlite_reg_ops *reg_ops = port->private_data; > + const struct uartlite_reg_ops *reg_ops = port->private_data; > > return reg_ops->in(port->membase + offset); > } > > static inline void uart_out32(u32 val, u32 offset, struct uart_port *port) > { > - struct uartlite_reg_ops *reg_ops = port->private_data; > + const struct uartlite_reg_ops *reg_ops = port->private_data; > > reg_ops->out(val, port->membase + offset); > } > -- > 2.4.3 > > > -- > Kind Regards, > Aya Saif El-yazal Mahfouz Kindly drop this patch. I'm retracting it since it will introduce two build warnings and fixing it will not be a simple process. -- Kind Regards, Aya Saif El-yazal Mahfouz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/