Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965230AbbLOOzS (ORCPT ); Tue, 15 Dec 2015 09:55:18 -0500 Received: from mail-ob0-f175.google.com ([209.85.214.175]:34645 "EHLO mail-ob0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751996AbbLOOzQ (ORCPT ); Tue, 15 Dec 2015 09:55:16 -0500 MIME-Version: 1.0 In-Reply-To: <20151214190808.364f1c9b@gmail.com> References: <1449542244-637-1-git-send-email-jpage.lkml@gmail.com> <20151208130905.GX6520@io.lakedaemon.net> <20151214190808.364f1c9b@gmail.com> Date: Tue, 15 Dec 2015 07:55:15 -0700 Message-ID: Subject: Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header file. From: Mathieu Poirier To: Sanidhya Solanki Cc: Jason Cooper , Greg KH , deepa.kernel@gmail.com, =?UTF-8?B?QnVyw6dpbiBBa2FsxLFu?= , Vatika Harlalka , sudipm.mukherjee@gmail.com, devel@driverdev.osuosl.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2684 Lines: 75 On 14 December 2015 at 17:08, Sanidhya Solanki wrote: > The original code defined macros in the source code, making it > harder to read. Moved them to the header file, as per the TODO file. > > Updated the TODO file. > > Signed-off-by: Sanidhya Solanki > --- > drivers/staging/skein/TODO | 1 - > drivers/staging/skein/skein_block.c | 6 ------ > drivers/staging/skein/skein_block.h | 7 +++++++ > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/skein/TODO b/drivers/staging/skein/TODO > index cd3508d..e3de0c7 100644 > --- a/drivers/staging/skein/TODO > +++ b/drivers/staging/skein/TODO > @@ -1,6 +1,5 @@ > skein/threefish TODO > > - - move macros into appropriate header files > - add / pass test vectors > - module support > > diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c > index 45b4732..2120392 100644 > --- a/drivers/staging/skein/skein_block.c > +++ b/drivers/staging/skein/skein_block.c > @@ -26,12 +26,6 @@ > #define SKEIN_LOOP 001 /* default: unroll 256 and 512, but not 1024 */ > #endif > > -#define BLK_BITS (WCNT * 64) /* some useful definitions for code here */ > -#define KW_TWK_BASE (0) > -#define KW_KEY_BASE (3) > -#define ks (kw + KW_KEY_BASE) > -#define ts (kw + KW_TWK_BASE) > - > #ifdef SKEIN_DEBUG > #define debug_save_tweak(ctx) \ > { \ > diff --git a/drivers/staging/skein/skein_block.h b/drivers/staging/skein/skein_block.h > index 9d40f4a..0fd4bfe 100644 > --- a/drivers/staging/skein/skein_block.h > +++ b/drivers/staging/skein/skein_block.h > @@ -7,6 +7,13 @@ > ** This algorithm and source code is released to the public domain. > ** > ************************************************************************/ > + > +#define BLK_BITS (WCNT * 64) /* some useful definitions for code here */ > +#define KW_TWK_BASE (0) > +#define KW_KEY_BASE (3) > +#define ks (kw + KW_KEY_BASE) > +#define ts (kw + KW_TWK_BASE) > + > #ifndef _SKEIN_BLOCK_H_ > #define _SKEIN_BLOCK_H_ > > -- > 2.5.0 > I must admit you lost me here - what is this new version about? I suggest you used the [PATCH v#] convention along with a log of modifications from one version to another when sending new revisions. That way people know what to look for. Thanks, Mathieu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/