Subject: Re: [PATCH v2 1/3] x86/xen: Avoid fast syscall path for Xen PV guests
To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com
References: <1447970147-1733-1-git-send-email-boris.ostrovsky@oracle.com>
 <1447970147-1733-2-git-send-email-boris.ostrovsky@oracle.com>
Cc: david.vrabel@citrix.com, konrad.wilk@oracle.com, luto@kernel.org,
        bp@suse.de, linux-kernel@vger.kernel.org,
        xen-devel@lists.xenproject.org,
        virtualization@lists.linux-foundation.org
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <56703001.9010205@oracle.com>
Date: Tue, 15 Dec 2015 10:21:37 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <1447970147-1733-2-git-send-email-boris.ostrovsky@oracle.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1166
Lines: 32

On 11/19/2015 04:55 PM, Boris Ostrovsky wrote:
> After 32-bit syscall rewrite, and specifically after commit 5f310f739b4c
> ("x86/entry/32: Re-implement SYSENTER using the new C path"), the stack
> frame that is passed to xen_sysexit is no longer a "standard" one (i.e.
> it's not pt_regs).
>
> Since we end up calling xen_iret from xen_sysexit we don't need to fix
> up the stack and instead follow entry_SYSENTER_32's IRET path directly
> to xen_iret.
>
> We can do the same thing for compat mode even though stack does not need
> to be fixed. This will allow us to drop usergs_sysret32 paravirt op (in
> the subsequent patch)
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Suggested-by: Andy Lutomirski <luto@amacapital.net>


I know this has been in the tip tree --- when do you think this will go 
Linus tree? In the 4.4 timeframe?

Xen 32-bit PV guests are broken without this.


Thanks.
-boris

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/