Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933694AbbLORsM (ORCPT ); Tue, 15 Dec 2015 12:48:12 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:47973 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933282AbbLORsK (ORCPT ); Tue, 15 Dec 2015 12:48:10 -0500 Date: Tue, 15 Dec 2015 12:48:07 -0500 (EST) Message-Id: <20151215.124807.81023600107235690.davem@davemloft.net> To: ben@decadent.org.uk Cc: gregkh@linuxfoundation.org, dsa@cumulusnetworks.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, nikolay@cumulusnetworks.com Subject: Re: [PATCH 4.3] vrf: Fix memory leak on registration failure in vrf_newlink() From: David Miller In-Reply-To: <20151215151243.GN28542@decadent.org.uk> References: <20151215054004.GA30221@kroah.com> <20151215151243.GN28542@decadent.org.uk> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 15 Dec 2015 09:48:10 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 686 Lines: 18 From: Ben Hutchings Date: Tue, 15 Dec 2015 15:12:43 +0000 > The backported version of commit 7f109f7cc371 ("vrf: fix double free > and memory corruption on register_netdevice failure") incorrectly > removed a kfree() from the failure path as well as the free_netdev(). > Add that back. > > Signed-off-by: Ben Hutchings Thanks for catching this: Acked-by: David S. Miller -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/