MIME-Version: 1.0
In-Reply-To: <CALCETrV5kRXLAomsPUGKsZiL9Um4NioTqaLqoCzxGCJDRQUX+g@mail.gmail.com>
References: <20151115070022.GA15417@amd>
	<20151214080403.GA3708@amd>
	<20151214085803.GA10520@pd.tnic>
	<20151214090726.GA6472@amd>
	<CA+55aFwivS6pnNKqy6aFrh4H5HC2izW_Rw0GL1hV9EdbV+HhkA@mail.gmail.com>
	<20151214202627.GA15104@amd>
	<CALCETrX6DrW2AJz=WGjMW+nNTsq08+Cte0m=CF_Q9+uzsuR1vA@mail.gmail.com>
	<566F3378.8070009@linux.intel.com>
	<CALCETrW60DfZs-v_W46sYFUmBXspa3BXWY-=dpuSF9iMaeLGFQ@mail.gmail.com>
	<20151215094015.GA3677@amd>
	<CA+55aFyp91uoxPV=NTNpWOLWkfV9QB=0WKZBtF2cdBNC8Q6LSA@mail.gmail.com>
	<CALCETrV5kRXLAomsPUGKsZiL9Um4NioTqaLqoCzxGCJDRQUX+g@mail.gmail.com>
Date: Tue, 15 Dec 2015 11:08:05 -0800
Message-ID: <CA+55aFytYbvzKcouORDGREPdvXWvUibuxe2opeBhpXxRxZcvKg@mail.gmail.com>
Subject: Re: 4.4-rc5: ugly warn on: 5 W+X pages found
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Pavel Machek <pavel@ucw.cz>, Arjan van de Ven <arjan@linux.intel.com>,
        Borislav Petkov <bp@alien8.de>,
        kernel list <linux-kernel@vger.kernel.org>,
        Stephen Smalley <sds@tycho.nsa.gov>, Brian Gerst <brgerst@gmail.com>,
        Denys Vlasenko <dvlasenk@redhat.com>, Peter Anvin <hpa@zytor.com>,
        Mike Galbraith <efault@gmx.de>, Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 718
Lines: 18

On Tue, Dec 15, 2015 at 10:40 AM, Andy Lutomirski <luto@amacapital.net> wrote:
>
> Shouldn't we switch those two lines?

No. This is for debugging Pavel's issue. If somehow the
__supported_pte_mask ends up having NX clear again (memory scribble,
whatever), we very explicitly would want to catch that.

I'm *not* suggesting this as a generic patch to be applied anywhere
else. That patch is meant to debug Pavel's particular setup, and
nothing else.

                Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/