Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754313AbbLOTXH (ORCPT ); Tue, 15 Dec 2015 14:23:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40249 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754288AbbLOTXF (ORCPT ); Tue, 15 Dec 2015 14:23:05 -0500 Date: Tue, 15 Dec 2015 17:23:03 -0200 From: "Herton R. Krzesinski" To: Peter Hurley Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby Subject: Re: [PATCH] pty: fix use after free of tty->driver_data Message-ID: <20151215192303.GD20334@dhcppc10.redhat.com> References: <1450150179-20925-1-git-send-email-herton@redhat.com> <1450150179-20925-2-git-send-email-herton@redhat.com> <56704F9A.6050006@hurleysoftware.com> <20151215180509.GC20334@dhcppc10.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151215180509.GC20334@dhcppc10.redhat.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1232 Lines: 30 On Tue, Dec 15, 2015 at 04:05:09PM -0200, Herton R. Krzesinski wrote: > On Tue, Dec 15, 2015 at 09:36:26AM -0800, Peter Hurley wrote: > > > > > > > Signed-off-by: Herton R. Krzesinski > > > Cc: > > > > Afaict, the stable tag goes back to the original implementation. > > Did you research how far back the /dev/tty alias problem goes? > > Hmm no. I did cc stable because the first report I got about this issue > was on RHEL 7 with 3.10 based kernel, so this issue goes far back > some releases that are still supported and similar code is there. > > On a quick check on a 2.6.32 kernel, things were very different, > tty_release_dev() called directly devpts_kill_index with inode > from the same file being closed. I'll check more and adjust the tag. FYI, checked here and the problem should start with 3.8, after commit fa2ecfc5a68d85624bbd84f7d010860776b7e602 devpts_kill_index was moved to pty.c/pty_unix98_shutdown -- []'s Herton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/