Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932462AbbLOTvs (ORCPT ); Tue, 15 Dec 2015 14:51:48 -0500 Received: from mx0b-0016ce01.pphosted.com ([67.231.156.153]:60114 "EHLO mx0b-0016ce01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754121AbbLOTvr convert rfc822-to-8bit (ORCPT ); Tue, 15 Dec 2015 14:51:47 -0500 From: Joe Carnuccio To: Chad Dupuis , Nicholas Krause CC: Dept-Eng QLogic Storage Upstream , "JBottomley@odin.com" , "martin.petersen@oracle.com" , linux-scsi , linux-kernel Subject: RE: [PATCH] bnx2fc:Add proper locking protection in bnx2fc_ctrlr_enabled Thread-Topic: [PATCH] bnx2fc:Add proper locking protection in bnx2fc_ctrlr_enabled Thread-Index: AQHRNRTTUsX76hWcgEq4CFUP/9RRZp7MyysA//+tlmA= Date: Tue, 15 Dec 2015 19:51:34 +0000 Message-ID: <86A17A977688E04689F40F6B1EC20EC60194111FCC@AVMB1.qlogic.org> References: <1449949166-3977-1-git-send-email-xerofoify@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.4.10] disclaimer: bypass Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5700 definitions=8016 signatures=670673 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1011 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310007 definitions=main-1512150325 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2201 Lines: 58 Also, the patch fails to do what it's message describes, i.e. the calls _bnx2fc_enable() and _bnx2fc_disable() are outside the lock/unlock. -----Original Message----- From: Chad Dupuis Sent: Tuesday, December 15, 2015 8:43 AM To: Nicholas Krause Cc: Dept-Eng QLogic Storage Upstream ; JBottomley@odin.com; martin.petersen@oracle.com; linux-scsi ; linux-kernel Subject: Re: [PATCH] bnx2fc:Add proper locking protection in bnx2fc_ctrlr_enabled On Sat, 12 Dec 2015, Nicholas Krause wrote: > This adds proper locking protection in bnx2fc_ctrl_enabled around the > calls to the functions, _bnx2fc_enable and _bnx2fc_disable in order to > avoid concurrent access on these functions accessing global referenced > data structures in their internal intended work. > > Signed-off-by: Nicholas Krause > --- > drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c > b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c > index 67405c6..e43648f 100644 > --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c > +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c > @@ -2177,13 +2177,21 @@ static int bnx2fc_ctlr_enabled(struct > fcoe_ctlr_device *cdev) { > struct fcoe_ctlr *ctlr = fcoe_ctlr_device_priv(cdev); > > + rtnl_lock(); > + mutex_lock(&bnx2fc_dev_lock); > switch (cdev->enabled) { > case FCOE_CTLR_ENABLED: > + rtnl_unlock(); > + mutex_unlock(&bnx2fc_dev_lock); > return __bnx2fc_enable(ctlr); > case FCOE_CTLR_DISABLED: > + rtnl_unlock(); > + mutex_unlock(&bnx2fc_dev_lock); > return __bnx2fc_disable(ctlr); > case FCOE_CTLR_UNUSED: > default: > + rtnl_unlock(); > + mutex_unlock(&bnx2fc_dev_lock); > return -ENOTSUPP; > }; > } > Nack. All we end up protecting is the check of cdev->enabled and I do not believe taking two mutexes is required for that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/