Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933723AbbLOVBS (ORCPT ); Tue, 15 Dec 2015 16:01:18 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:51278 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753236AbbLOVBQ (ORCPT ); Tue, 15 Dec 2015 16:01:16 -0500 Date: Tue, 15 Dec 2015 16:01:14 -0500 (EST) Message-Id: <20151215.160114.1178824607335349574.davem@davemloft.net> To: bjorn.andersson@sonymobile.com Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, netdev@vger.kernel.org, srinivas.kandagatla@linaro.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, courtney.cavin@sonymobile.com Subject: Re: [PATCH] net: add Qualcomm IPC router From: David Miller In-Reply-To: <1449866519-14551-1-git-send-email-bjorn.andersson@sonymobile.com> References: <1449866519-14551-1-git-send-email-bjorn.andersson@sonymobile.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 15 Dec 2015 13:01:16 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 20 From: Bjorn Andersson Date: Fri, 11 Dec 2015 12:41:59 -0800 > +static unsigned int qrtr_local_nid = 1; > +module_param_named(node_id, qrtr_local_nid, uint, S_IRUGO); > +MODULE_PARM_DESC(idVendor, "Local Node Identifier"); Module parameters suck. Allow the user to choose this dynamically. You have roughtly two choices. 1) Subvert the 'protocol' field passed to ->create() and use that, it is being ignored otherwise. 2) Put it into the socket address for bind(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/