Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933707AbbLOVeJ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Dec 2015 16:34:09 -0500
Received: from mail.skyhub.de ([78.46.96.112]:52780 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932339AbbLOVeH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Dec 2015 16:34:07 -0500
Date: Tue, 15 Dec 2015 22:33:59 +0100
From: Borislav Petkov <bp@alien8.de>
To: Pavel Machek <pavel@ucw.cz>,
        Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
        Arjan van de Ven <arjan@linux.intel.com>,
        kernel list <linux-kernel@vger.kernel.org>,
        Stephen Smalley <sds@tycho.nsa.gov>, Brian Gerst <brgerst@gmail.com>,
        Denys Vlasenko <dvlasenk@redhat.com>, Peter Anvin <hpa@zytor.com>,
        Mike Galbraith <efault@gmx.de>, Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: 4.4-rc5: ugly warn on: 5 W+X pages found
Message-ID: <20151215213359.GM25973@pd.tnic>
References: <20151214085803.GA10520@pd.tnic>
 <20151214090726.GA6472@amd>
 <CA+55aFwivS6pnNKqy6aFrh4H5HC2izW_Rw0GL1hV9EdbV+HhkA@mail.gmail.com>
 <20151214202627.GA15104@amd>
 <CALCETrX6DrW2AJz=WGjMW+nNTsq08+Cte0m=CF_Q9+uzsuR1vA@mail.gmail.com>
 <566F3378.8070009@linux.intel.com>
 <CALCETrW60DfZs-v_W46sYFUmBXspa3BXWY-=dpuSF9iMaeLGFQ@mail.gmail.com>
 <20151215094015.GA3677@amd>
 <CA+55aFyp91uoxPV=NTNpWOLWkfV9QB=0WKZBtF2cdBNC8Q6LSA@mail.gmail.com>
 <20151215205835.GA3522@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20151215205835.GA3522@amd>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2010
Lines: 58

On Tue, Dec 15, 2015 at 09:58:35PM +0100, Pavel Machek wrote:
> [    0.000000] Base memory trampoline at [c009b000] 9b000 size 16384
> [    0.000000] ------------[ cut here ]------------
> [    0.000000] WARNING: CPU: 0 PID: 0 at
> ./arch/x86/include/asm/pgtable.h:357 kernel_physical_mapping_init+0x
> 256/0x395()
> [    0.000000] Modules linked in:
> [    0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 4.4.0-rc5+ #137
> [    0.000000] Hardware name: LENOVO 17097HU/17097HU, BIOS 7BETD8WW
> (2.19 ) 03/31/2011
> [    0.000000]  00000000 00000000 c4e63e90 c42baaf8 00000000 c4e63eac
> c404066b 00000165
> [    0.000000]  c4f134da 00000000 00000000 00000000 c4e63ebc c404070f
> 00000009 00000000
> [    0.000000]  c4e63f18 c4f134da c4e63f00 00000000 00000000 00000000
> 00000000 00000000
> [    0.000000] Call Trace:
> [    0.000000]  [<c42baaf8>] dump_stack+0x41/0x59
> [    0.000000]  [<c404066b>] warn_slowpath_common+0x6b/0xa0
> [    0.000000]  [<c4f134da>] ?
> kernel_physical_mapping_init+0x256/0x395
> [    0.000000]  [<c404070f>] warn_slowpath_null+0xf/0x20
> [    0.000000]  [<c4f134da>] kernel_physical_mapping_init+0x256/0x395
> [    0.000000]  [<c4a4de21>] init_memory_mapping+0x191/0x300
> [    0.000000]  [<c4f12d96>] init_mem_mapping+0xe7/0x1f3

Looks like the ISA range to me:

init_mem_mapping:

	...

        /* the ISA range is always mapped regardless of memory holes */
        init_memory_mapping(0, ISA_END_ADDRESS);

Does that kernel_physical_mapping_init() even pay attention to
__supported_pte_mask and thus _PAGE_NX? I don't see it.

Hmm, not really:

	pgprot_t init_prot = __pgprot(PTE_IDENT_ATTR | _PAGE_PSE);

	...

	prot = PAGE_KERNEL_LARGE_EXEC;

	...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/