Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933934AbbLPCVh (ORCPT ); Tue, 15 Dec 2015 21:21:37 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36176 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932662AbbLPCVg (ORCPT ); Tue, 15 Dec 2015 21:21:36 -0500 Date: Tue, 15 Dec 2015 17:20:12 -0500 From: Sanidhya Solanki To: Mathieu Poirier Cc: Jason Cooper , Greg KH , deepa.kernel@gmail.com, =?UTF-8?B?QnVyw6dp?= =?UTF-8?B?biBBa2FsxLFu?= , Vatika Harlalka , sudipm.mukherjee@gmail.com, devel@driverdev.osuosl.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header file. Message-ID: <20151215172012.534de4fe@gmail.com> In-Reply-To: References: <1449542244-637-1-git-send-email-jpage.lkml@gmail.com> <20151208130905.GX6520@io.lakedaemon.net> <20151214190808.364f1c9b@gmail.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 839 Lines: 17 On Tue, 15 Dec 2015 07:55:15 -0700 Mathieu Poirier wrote: > I must admit you lost me here - what is this new version about? I > suggest you used the [PATCH v#] convention along with a log of > modifications from one version to another when sending new revisions. > That way people know what to look for. It moves the macros that were not nested inside functions to the header file. See how all the "defines" in the code are moved to skein_block.h? The patch just changes 7 lines. The change was on the TODO list, under the heading "Move macros to header files." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/