From: Eric Anholt <eric@anholt.net>
To: Florian Fainelli <f.fainelli@gmail.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Stephen Warren <swarren@wwwdotorg.org>,
        Lee Jones <lee@kernel.org>, Kevin Hilman <khilman@kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alexander Aring <alex.aring@gmail.com>, devicetree@vger.kernel.org,
        linux-pm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>
Subject: Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver
In-Reply-To: <567093CD.1020208@gmail.com>
References: <1450215622-27394-1-git-send-email-eric@anholt.net> <1450215622-27394-3-git-send-email-eric@anholt.net> <567093CD.1020208@gmail.com>
User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu)
Date: Tue, 15 Dec 2015 15:55:17 -0800
Message-ID: <87oadrmfmi.fsf@eliezer.anholt.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3062
Lines: 73

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Florian Fainelli <f.fainelli@gmail.com> writes:

> On 15/12/15 13:40, Eric Anholt wrote:
>> From: Alexander Aring <alex.aring@gmail.com>
>>=20
>> This patch adds support for several power domains on Raspberry Pi,
>> including USB (so it can be enabled even if the bootloader didn't do
>> it), and graphics.
>>=20
>> This patch is the combined work of Eric Anholt (who wrote USB support
>> inside of the Raspberry Pi firmware driver, and wrote the non-USB
>> domain support) and Alexander Aring (who separated the original USB
>> work out from the firmware driver).
>>=20
>> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> ---
>>=20
>> v2: Add support for power domains other than USB, using the new
>>     firmware interface, reword commit message (changes by Eric)
>>=20
>> v3: Restructure as a builtin driver, and drop
>>     of_genpd_add_provider_onecell error handling to avoid
>>     pm_genpd_exit() dependency until that API can be settled.  Clean
>>     up copyright header, add missing ISP initialization, and fix typo
>>     in transposer's name.
>>=20
>>  arch/arm/mach-bcm/Kconfig                   |  10 ++
>>  arch/arm/mach-bcm/Makefile                  |   1 +
>>  arch/arm/mach-bcm/raspberrypi-power.c       | 247 +++++++++++++++++++++=
+++++++
>>  include/dt-bindings/arm/raspberrypi-power.h |  41 +++++
>>  4 files changed, 299 insertions(+)
>>  create mode 100644 arch/arm/mach-bcm/raspberrypi-power.c
>
> What motivated the location of this power domain driver in
> arch/arm/mach-bcm? Should not we have this in drivers/power/ or
> somewhere in drivers/ at the very least?

ls stronly suggests that power contains drivers for power supplies and
batteries, not power domains.  There are 6 power domain drivers in
arch/arm, 3 in drivers/clk, and 3 in drivers/soc.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJWcKhlAAoJELXWKTbR/J7oUFoQAJDrZ706sJWLuIqRUwoQmxUP
KJAB/9iUdeIeHJVtVGpOo6Fce9WyHcMYM98t5ZdKt3/ZD4GUA3HY1QAsoFB/op/z
/ZsjzDPFi7LlgWPRJb/ZD7vrYku7MYlHsHNGaHR1JjPaYTBH4g7UnfJD4BaUG6Ct
4Jm0jReNKdIhbBcSsqkE8LDqNNeTqAC64tFjcN6S7esIuNdjbA49BWP0rpglsDvN
wmequkyXs9kG8GpTwdlvOxuZB1kZWIlMFcDAPsY5uUkb8d9mhrXmfoKaRmYLiQZe
PDFQvsvByR3S1iBczGK5z83hN4imeBmvTZ/WURgQSmxYn85l5NbQsSKNR+Vvu8uM
ZBxsrRnnt1ZKzk2wFzOpKAJli0vXwX8m3f52Wo51XfRz1XFRJH+msxDpXwuJzsYC
fhuhF8iWufpj1Jvk7ZOBNuX/mTzpPH7n1tllXFRrTqAAGADT/wtqAmoxa5lqxKrL
sQ3EdyWojNoH5bMsfxsPT/O9+WBjFl6EGJ1iT/OLkJgxptSQ14MjNyyDcwjj8Luc
91jkBgEHIhabTjovjBlrc1QR1Mb7PPlHeE2zeq5dnYHV/BmTWDLXW5Kzq+isrR5B
tMq2W2C1VYwujQqjNBsDXj5ar70ve4PUyjcigvhJdjRDukJkCtHOBNRzFG87k4EQ
inJcYnrpO82zf0b91saf
=sX4c
-----END PGP SIGNATURE-----
--=-=-=--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/